From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751657AbdAaSiX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Jan 2017 13:38:23 -0500
Received: from mail.skyhub.de ([78.46.96.112]:51441 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751863AbdAaSiO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Jan 2017 13:38:14 -0500
Date: Tue, 31 Jan 2017 19:37:49 +0100
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Erik Veijola <erik.veijola@intel.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] x86/mce: Make timer handling more robust
Message-ID: <20170131183749.32ol7i7qnjfa35qx@pd.tnic>
References: <alpine.DEB.2.20.1701310936080.3457@nanos>
 <alpine.DEB.2.20.1701311432080.3457@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1701311432080.3457@nanos>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2017 at 02:33:29PM +0100, Thomas Gleixner wrote:
> On Tue, 31 Jan 2017, Thomas Gleixner wrote:
> > +static void mce_start_timer(struct timer_list *t)
> >  {
> >  	unsigned long iv = check_interval * HZ;
> >  
> >  	if (mca_cfg.ignore_ce || !iv)
> >  		return;
> >  
> > -	per_cpu(mce_next_interval, cpu) = iv;
> > -
> > -	t->expires = round_jiffies(jiffies + iv);
> > -	add_timer_on(t, cpu);
> > +	this_cpu_write(mce_next_interval, iv);
> > +	__start_timer(t, jiffies + iv);
> 
> Bah. That's wrong. Delta patch below:
> 
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -1782,7 +1782,7 @@ static void mce_start_timer(struct timer
>  		return;
>  
>  	this_cpu_write(mce_next_interval, iv);
> -	__start_timer(t, jiffies + iv);
> +	__start_timer(t, iv);
>  }
>  
>  static void __mcheck_cpu_setup_timer(void)

With that hunk merged in:

Reviewed-by: Borislav Petkov <bp@suse.de>
Tested-by: Borislav Petkov <bp@suse.de>

Thanks!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.