From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbdAaULd (ORCPT ); Tue, 31 Jan 2017 15:11:33 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36548 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbdAaULZ (ORCPT ); Tue, 31 Jan 2017 15:11:25 -0500 Date: Tue, 31 Jan 2017 21:11:20 +0100 From: Daniel Vetter To: Liviu Dudau Cc: David Airlie , Daniel Vetter , Jonathan Corbet , LKML , DRI devel , linux-doc@vger.kernel.org Subject: Re: [PATCH] Documentation/gpu: drm-mm.rst: fix formatting for struct vm_operations_struct Message-ID: <20170131201120.6vd22b6v5dfibo7x@phenom.ffwll.local> Mail-Followup-To: Liviu Dudau , David Airlie , Daniel Vetter , Jonathan Corbet , LKML , DRI devel , linux-doc@vger.kernel.org References: <20170131174109.13690-1-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170131174109.13690-1-Liviu.Dudau@arm.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 05:41:09PM +0000, Liviu Dudau wrote: > drm-mm.rst contains some unformatted dump of the vm_operations_struct > structure. Add some C formatting around it and some context for the > dump. While there, update the structure to resemble the new signature > for the fault handler after commit 25d3db7600b8 (mm, fs: reduce fault, > page_mkwrite, and pfn_mkwrite to take only vmf). > > Signed-off-by: Liviu Dudau Applied, thanks. -Daniel > --- > Documentation/gpu/drm-mm.rst | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst > index 91d82f39fbf4..a1c0ae3b2c38 100644 > --- a/Documentation/gpu/drm-mm.rst > +++ b/Documentation/gpu/drm-mm.rst > @@ -291,10 +291,17 @@ To use :c:func:`drm_gem_mmap()`, drivers must fill the struct > :c:type:`struct drm_driver ` gem_vm_ops field > with a pointer to VM operations. > > -struct vm_operations_struct \*gem_vm_ops struct > -vm_operations_struct { void (\*open)(struct vm_area_struct \* area); > -void (\*close)(struct vm_area_struct \* area); int (\*fault)(struct > -vm_area_struct \*vma, struct vm_fault \*vmf); }; > +The VM operations is a :c:type:`struct vm_operations_struct ` > +made up of several fields, the more interesting ones being: > + > +.. code-block:: c > + > + struct vm_operations_struct { > + void (*open)(struct vm_area_struct * area); > + void (*close)(struct vm_area_struct * area); > + int (*fault)(struct vm_fault *vmf); > + }; > + > > The open and close operations must update the GEM object reference > count. Drivers can use the :c:func:`drm_gem_vm_open()` and > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch