From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbdBAHJp (ORCPT ); Wed, 1 Feb 2017 02:09:45 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48715 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbdBAHJo (ORCPT ); Wed, 1 Feb 2017 02:09:44 -0500 Date: Wed, 1 Feb 2017 08:09:37 +0100 From: Sascha Hauer To: Martin Kaiser Cc: Shawn Guo , Sascha Hauer , Steffen Trumtrar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers Message-ID: <20170201070937.pcblnpebxb65llto@pengutronix.de> References: <1485890402-22974-1-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485890402-22974-1-git-send-email-martin@kaiser.cx> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:05:37 up 40 days, 15:24, 19 users, load average: 0.13, 0.05, 0.01 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 08:20:01PM +0100, Martin Kaiser wrote: > The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of > control registers. Add the memory regions for the control registers to > the Device Tree. > > All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as > well. Indicate that we are compatible to fsl,imx53-aipstz. However, > don't use aipstz for our name, this seems to be specific to i.MX53. > > Signed-off-by: Martin Kaiser > --- > arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index e0ba550..4c4768f 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -93,6 +93,11 @@ > reg = <0x43f00000 0x100000>; > ranges; > > + aips1: bridge@43f00000 { > + compatible = "fsl,imx25-aips", "fsl,imx53-aipstz"; > + reg = <0x43f00000 0x60>; > + }; The additional compatible properties should indicate if there is an older ip block this one is compatible to. Since i.MX53 is newer than i.MX25 this goes into the wrong direction. If anything you could add the "fsl,imx25-aips" compatible to the i.MX53 dtsi file, but I don't think that's worth it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |