From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbdBAJqL (ORCPT ); Wed, 1 Feb 2017 04:46:11 -0500 Received: from foss.arm.com ([217.140.101.70]:55350 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbdBAJqJ (ORCPT ); Wed, 1 Feb 2017 04:46:09 -0500 Date: Wed, 1 Feb 2017 09:45:56 +0000 From: Liviu Dudau To: Lucas Stach Cc: Liviu Dudau , Dave Jiang , LKML , DRI devel , etnaviv@lists.freedesktop.org, Russell King Subject: Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition. Message-ID: <20170201094556.GM3140@e110455-lin.cambridge.arm.com> References: <20170131185849.8297-1-liviu@dudau.co.uk> <20170131185849.8297-2-liviu@dudau.co.uk> <1485941168.21479.38.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1485941168.21479.38.camel@pengutronix.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 10:26:08AM +0100, Lucas Stach wrote: > Hi Liviu, > > Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau: > > Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite > > to take only vmf") updated the etnaviv_gem_fault() function signature > > without updating the header file with the declaration. > > > There is already a patch from Arnd on the list that fixes this issue. Sorry, my search-fu was not strong enough. Thanks for pointing it out. Best regards, Liviu > > https://lkml.org/lkml/2017/1/25/718 > > Regards, > Lucas > > > Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf") > > Cc: Dave Jiang > > Cc: Lucas Stach > > Cc: Russell King > > Cc: Christian Gmeiner > > Signed-off-by: Liviu Dudau > > --- > > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > > index c255eda40526..e41f38667c1c 100644 > > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > > @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, > > struct drm_file *file); > > > > int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma); > > -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf); > > +int etnaviv_gem_fault(struct vm_fault *vmf); > > int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset); > > struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj); > > void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj); > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯