From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbdBALRp (ORCPT ); Wed, 1 Feb 2017 06:17:45 -0500 Received: from mga01.intel.com ([192.55.52.88]:3827 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbdBALRn (ORCPT ); Wed, 1 Feb 2017 06:17:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,319,1477983600"; d="scan'208";a="815779193" Date: Wed, 1 Feb 2017 13:17:34 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-sysfs.c Message-ID: <20170201111734.77s4j7zuptik5epx@intel.com> References: <1485888239-7727-1-git-send-email-stefanb@linux.vnet.ibm.com> <20170131203714.phz6dpmbyaynbs44@intel.com> <20170201080839.l46vyziwwgusnu7a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201080839.l46vyziwwgusnu7a@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 10:08:39AM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 31, 2017 at 10:37:14PM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 31, 2017 at 01:43:59PM -0500, Stefan Berger wrote: > > > drivers/char/tpm/tpm-sysfs.c:161:25: warning: expression using sizeof bool > > > > > > Fixes: c659af78eb7b ("tpm: Check size of response before accessing data") > > > Signed-off-by: Stefan Berger > > > --- > > > drivers/char/tpm/tpm.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > > index bff37be..6b4e7aa 100644 > > > --- a/drivers/char/tpm/tpm.h > > > +++ b/drivers/char/tpm/tpm.h > > > @@ -281,7 +281,7 @@ struct permanent_flags_t { > > > typedef union { > > > struct permanent_flags_t perm_flags; > > > struct stclear_flags_t stclear_flags; > > > - bool owned; > > > + __u8 owned; > > > __be32 num_pcrs; > > > struct tpm_version_t tpm_version; > > > struct tpm_version_1_2_t tpm_version_1_2; > > > -- > > > 2.4.3 > > > > A better description would be: > > > > The field owned has wrong sized type. This commit fixes the > > issue. > > > > ? > > > > /Jarkko > > And doesn't owned print invalid results on a big endian system > i.e. 0x1000000? The commit message needs to be rewritten to capture > the problem. Please ignore this, the conversion is done in tpm_getcap(). I'll update the commit message. /Jarkko