From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbdBALno (ORCPT ); Wed, 1 Feb 2017 06:43:44 -0500 Received: from mail-cys01nam02on0080.outbound.protection.outlook.com ([104.47.37.80]:57508 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbdBALnk (ORCPT ); Wed, 1 Feb 2017 06:43:40 -0500 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;nxp.com; dkim=none (message not signed) header.d=none; From: To: CC: , , , , , , , , , , , Laurentiu Tudor Subject: [PATCH 1/9] staging: fsl-mc: drop root dprc counting Date: Wed, 1 Feb 2017 05:43:21 -0600 Message-ID: <20170201114329.21276-2-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170201114329.21276-1-laurentiu.tudor@nxp.com> References: <20170201114329.21276-1-laurentiu.tudor@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131304230181834424;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(7916002)(39410400002)(39380400002)(39850400002)(39400400002)(39840400002)(39860400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(48376002)(106466001)(2351001)(7416002)(8936002)(50466002)(626004)(33646002)(4326007)(36756003)(2876002)(86362001)(105606002)(81156014)(76176999)(2906002)(1076002)(104016004)(97736004)(81166006)(8676002)(50986999)(50226002)(305945005)(356003)(92566002)(5660300001)(53936002)(85426001)(5003940100001)(189998001)(110136003)(6916009)(6666003)(2950100002)(54906002)(8656002)(47776003)(77096006)(86152003)(68736007)(38730400001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB2535;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD041;1:6HMd3s0QNJ/nPEo+hc08Vy6UyDx4tOYQ9ygez+lFAzQ+o0YZ/UXxv+DV7zpsTDKP5yAD6VSa7odi2mFiKx/QDxDzfmKBf/oZyK6BJ77P8J5VO7HfX9JCQf4VtO1Tf/T2UBsHhm0palmooJUWD9LWNLwQ4zaCiLdoyx5eK9VAUP05aYO2C6magfIrnnBpqonGa5Tt8sudeHYoEZPbIkOC3rewjo6wam7ggSFFLzzdmxm/L90rA20cItIBdhesmwRs6SWARq+f8bNK/ParjQanlg8La/z55Z5deJJ6i1tgOKr19sN6UnmlIA9VZIT1koxXIDxyM8YLOwY3YRX8OqMcJOgnXBQh8ItflK3jAFQxsIAH4OdM0Y97N8M08m1CmvHBiI96D7WvNd3cRnRL9+r5WTdfnql0yiYAs6iTvPb2DKQ+EMr3kLrIW8EkgkOibwwoTYUcWs0NM6SZvGOEPoBjT6JVR2eLhU4TiwGzPEeYNcumBLONlTvnq7DIW5TXkEl+pMNLExCq66iYoW8C0WPMLkjPQ7uYHFj4KZjKiK27UcxSazhH7A0IBqG2n/czBNrdaH8m3pJu7c5mQCRnsOdnYmN2K7vHjXtSpJV15CU2HjhoSaP6VaLTQCCtiMvuU82M2vpIJPN46JRPdK7lU0Ok3tynvZ3rhupwpUjUK15m1mDdNIgy9ZIsRUa/jLYaoDYDvgT1pn0syVX+RHEWdmOt2Q== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 38f79469-e42b-4ec6-2d58-08d44a978ff3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR03MB2535; X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;3:XAVpXuh0BUsz1ub9POEp00ScvSiAuH3+e/rXC0XUbm6HAi1rFPsenhwSuJbgd4B+5VcPnEYiKETaLC+EuBpoLQD+hOugalRnBIk3dUpMQh3b7vVMndyZe1gJx17mXQhEnmcAiRpJMkBNL2SoaPXJqogFgU+RcBzZM6jCrooyjYBMGhDFOHnfxIHqY+QXUG7bRQc6weeWWbRA3v5ApnPB237i6qMygDBG/0yfDmTOJ4Z5wyTex/i+g9OfgPkEH86PpI+gY49lODS4jsMpQw1azxqhDTcizRP86wyrjI7Vr2t1mchnIohVdqdQsEmE2LISTnAujy6grq0l50w0Vq1rSNP5T5EBLNrzwASBX2oJUbcA9CuHkdrvKrGNvyLefuhi X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;25:Ne/Ant2r3SaS6v8YS6qBqhcAziEtqmX7bB+Hz52oGvc9E6BPRdUcUiZRTx1yukHPJvOXYRnUMtBGVBMWfWt9OX9h5MkqFm3FvDoUQ0xGNT3CduClxZdOaCAlLWcf3TxRpoiAG2jIBKxKTMO0sz3PacCjBEIDKrmXdvzL9egoJq89uLrqKAitAb0/o88HU6/fEKy3vHEO4rWXINyMFzHOydlCaR2l4p7aeH9xM34YTj6kHEY34RFUcRXBbv86ivDdfJQ3Fhd5YeXnIL7IdtxqPCTOCo03/Hjt2G0ZrJsUO+9hUJMihwF4XKs1+hrdXs7VQxcdn9cEphe9H+Z+x25TCFfbsAALVjXR65n6ESyKx1R22yCNzEwTz2qHAWKPRZngg7acPd48c/QDZG22jrS7zYToa1yDm5JRkL5rls0R1AdGurwSnp1c7elzvZmp36rEkcldcM7WD/4WwwF9S/J8UpGFNbj9WyIDFFiAG9yKY0kE8nAjcSEjamwGSPxScS6Poo1qSiJkavP/6BP4f5V1EAj9ErdruR+2OG8IWtz5rBLY24eaZXjBJDq8T9lqgrWbsGq7RhJDaZhRgZbAVswJh4vzerOm9/LMcNtJPTuDlvgCHDnsWKtGAch1Yc4cOP9XQyjXfboVi4LhrfNtOP6s8aSjS/Ez5daAAAjd6bqNTsLY9oknuwB8kDla1NQEX/z0nbG31FYBa69r8V23sSmpiVIjSzDRG5TwWjsL8e01C3U= X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;31:+SsrmjPp7zN/67BethYivjK8zP2+/VnJ53gyp8UXVYb8SW+AtWhkus2Shgi7Bm8PZzIzsh9HpaGtC6Rn8ljBa0uTiUwqF5qTN6zZlVVMeU6n5Fw5clFzJ7MYsvUC9makf7Kd3lkFnb/7T1q9uHQzN4KtltoVWQgnnJx9zWXSTtWPA0tbV3b8tgElemeJjYJI96tU7YxG8blNR35eTYJu1VMD93xGBrtuK12Sida0cuYwmOOQa33jsMKcu78Z8t+ENQDUIObjOAEMr3GZkoOmQQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13024025)(13018025)(13015025)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123563025)(20161123559025)(20161123556025)(20161123565025);SRVR:CY4PR03MB2535;BCL:0;PCL:0;RULEID:(400006);SRVR:CY4PR03MB2535; X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;4:naHhqL0BCBmbTU/C/w/RedDisntRa8m9INXtF6dfkUyfZnK7qYxbdvWDtcdHuLadf57gkBj3QQg0PbqqTZqC3VRf4JPLmpbS20L3luIpobukFI8sH3P6FWZ3UI9VexJzmoi0aBFgl+oDVGzBYMccAwJax/HYkBHG1cSR+gLIjYIzGXhMug9nvK0UbnXDQpjQegXVNQvNR9+G9sfhU6v78NpOficCCphFmT1Uty3U/46aClzLU+by0+xd8gmcrR8trEY7S+Fe2jwtuWnGFVBTgH0t3rSh8EtPlItbvGPtmPHteqmIlCdigpMlxJRV66SjN9AFNXT/g3BOpcw0mbtvRHctkiO6EDa5SseLiHxjnfqh38uMNImkpLMMuMa3302lbD52/thk488/tLgChG/29PFrtwwj+/ODyswMh1NUu0uAj6jQ5seDM3BMcYD03At9+Uxk7pmUcNcgJdxewLH9a2O31o2USwJy836o2cccEWhuTqnxW5eUXiOchk3pSU5C6Ygg3l9IjfjlO5kYaqNUs+H5Ch4crZKXaiZfvayNSIf85kaum/iC3SblVO9MPXyertTJNpRytbiDe0FibazT7zHd5MhuRel65jEqyCOQcmAiNeunzgH9sw0L7NgIX1vjOc1w0Q9n0o3eZntrTV9ViUUuO3qoLG+ppFyuCooQ+sYnxF1jZagEmcKKLb9Nl5SgpOynuy7vFHDTDlAjZUwmYS/awKr9hmvVbLXodeBvxaeZ2QQysHUtgqGixzgNkEO7 X-Forefront-PRVS: 0205EDCD76 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR03MB2535;23:fvL2RPwKAbmrF6KnbNIANzM9HKWEtoLdnN2o5dcP8?= =?us-ascii?Q?8ZUxsY9VaLM8VHJW2Jl+Gvso7f0OSPzEu5VjGvNBYvibg1oTiU2hp6bKqm4g?= =?us-ascii?Q?U/xRAITs0UwlT0+bKh/9Wu4XXBsUWF1YwkdUljeHSMPT+1RKnfkzOR+Q65AD?= =?us-ascii?Q?GwSe7mN0vHHqWSPgyE9RD0OMzb/8sTI1SX/xVAnCNhDW4XvmWAXHvPtkPJbZ?= =?us-ascii?Q?85GawK71doYkCrnPT2/d7zEdrIgnQBUOitHQK9vLD5c6sBHOXbcNKtB7icde?= =?us-ascii?Q?PwSYUSkCT0JT2ZCu/9coPK3gdR1yKVv7xVXZ0uCaxUXJc9uxoMTsn2R1OqKe?= =?us-ascii?Q?fOnH0aEz9SHKBR9Z9FCRfwzTkW17l+jrdu12MznA/zlDlzrr83o/NQLXrPP5?= =?us-ascii?Q?aXcy04qbl5c1mj6q2aDCZHkG74rRGbgiTjxPmkShrm+8m4VxAN4BKGL3xXpe?= =?us-ascii?Q?5Hhnffdh8W6FOffJrdOXMQ87yJeYWXdtCeJDvD3WbB5Oca2doJOnLHKUjuNR?= =?us-ascii?Q?1bPT5XWkDF+/nzZwzdB5ghbKnazDF4lBymbIvQyhG7jcxWd984SdIEWWCPSG?= =?us-ascii?Q?qjpOGx+/W9jOXzX8+ymjDLUYcGfnTY4fbUqMdwfKvLKQqd7drEN6KCGLvhWM?= =?us-ascii?Q?0UCv/WmlaZhnkOii3lrquo1W4Km6cxtQP4Fu/R+uFHHB3t7abkjn16Ye16Hu?= =?us-ascii?Q?Gvpi7KMzf0h5V65WAEzJlJ6isiKkjW5Nq7ypIjVPPy72egeXz46sxf+oIHCy?= =?us-ascii?Q?Ps7uZolJEFyA8WzMuZVf/dIBUI23RCPg6NF0sgG3ICSWiURp3JmND3D8W+XA?= =?us-ascii?Q?lgacKkaEv3RlaD1CCDFKptfTv/HgKusblSpJaP6WxHnpYWHRsmE9jxiSQHbd?= =?us-ascii?Q?ymA5A/pWERnTNWgaTD0UcKX54DqqCHRR3EEt+AQ68ODYced1tFZmlZGeB1MV?= =?us-ascii?Q?mbBKaSRRfuBPJXp97Z+sd9Pdb0lmIqGvZOtC3gEiW7RQD/9b/hOMf2K8cVPE?= =?us-ascii?Q?DReBYooH/Ag2Ml6cYR9qOdiFZSB1YhAKaTiczz78Y1dBzZ/qb37314QIVneO?= =?us-ascii?Q?QG0cDtvH/YtRi7CrikwXJcwrksQZHkUNRcN3IIDM6pYWZXB40QhnfzGzJ3fu?= =?us-ascii?Q?rT8FZykz7zeKYKUiBgkY63Jp8uSQHvSKK3xUiejaP/qX4W0wxa9KmLb/c5Tx?= =?us-ascii?Q?WiNBfsVX0+ytzxt7Ban+Ys4SXS30ZEDG3IhCvtQ/s8e7ITfw856y4JZ3aceE?= =?us-ascii?Q?Rd3ICFyz9xw7W+2+1jbSH6PPn0Pc905uNLBhMjQsk5Y9iKeCXQCIbCN3C7Yq?= =?us-ascii?Q?MOVzOOuJjDXjlQ81tR3tvOEOsnpfcJX8IrUQC9Zn9iDPm0a0sqR8tp/TCTM6?= =?us-ascii?Q?l8Td8v64Whw7uauGFUoNXfMLLw=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;6:iFgVMDqWedmvm3Yi1s5v4Cf2CarxgA4GZyi5+5+5NrYnIXSkBtQHGBo4KQDl///E0tv9T1aCb7g59fytops4+hTnNfB7gj9N3gfPNIJ0QPqm8Vn8zsLLuIbEfGi2x/QjJr+/DVGtbRkUfX0vYPWWlOzjK8iz75LT6ssFUROq8JdLBf4eTXeqT8cYfyBLlN1+zk7KuC9Ux3USs5bLzA9lM3xuwDAq3XAsTORG9LHjCXmV+/agNd3niAevYkjLajf8xXXXw51Yy2GLoa0UKi+LSqwYXuM9gcirSKaDbiHWu2RJpqO2OJg+KHB/7cEXVSh1Qw/HyQUNfqsNKF94Ik5w7mHB9KWA6DuXGo9fBAnngrMB00UEPhfhEh1FvqOY/nwQY7IEU1MniaiH9LVVJ40oCHHAEnnCkz2jijLKCzQCnf3TD4iqVFXdc9RrdhbqNgZA;5:VbuQ4zyJIDVw1vGbsuHA09mFpJGkFILCD5mfL+SHl8jdoX13LUDZ35WA3PXeQPN8dqRHZJ6HnghkUxRtxBi4v0Mu2K0aYq4UCFSpWamrJsKtgssfuk9ytms1iZBFqTVA766RJFJhN9a92wAT86SHXLBDCBlicaqJcAsvT0tBxUEP4F4Ts6RC4aUZphgM/VPN;24:L/L8Zq6FtZA+UVKGJS5v0sAJcz/8p3isoriS1UEWmJ9ZSRlF5eMft3khrtTnwfghjuCJV7Jr1Pt0XyZQYIrjSSIs+O5ZEcZLD5UepJnLyAM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2535;7:KOMkmPivovmkp/v0KdyaptO0Fkx1LwrohIct9I852orsrk79kF1OX4ES/7I5XjRsP/cWTELpM64Nty11c1rSQAmCSrwG+txzmsKHWLWAMHqWOznPsiFH0BCiTzwp16pfvxScN7gGPDOcwz4ecZ3tb/GZe9N4X0HHlwFMtNlKAoK//TrqPJBlvBPyy3E+BLZ2yunA0zVekjeUHSARYOvuUPIc/RnNXA0jGUmI8PJgzl8lOkgRhmkeS4TKlYIJgVRNJRL/JVd4hggdnbEaJhHAXzqVm9RRZ5hMmkhTJA7TIzwZVnXWMvcMtBJsYYUs8aZSvSnRVywF4VyL07ALy6o8kF0ut101/jEJckzWrOYBS4x81azYZwa/e3tn0PyxLNHCJCaAn4UONecGbgEmsG2pqu/k732NeN7c8ZVwK3jrYju//Xr7zVoumfbt+xML3dneM57uD32/iLGsTTSdOml7xVQI2YnkHdmrwCBnabYuQP5eR0L3yx/hnUHIk3eNpjp7zBLIWFbyHl41fa+5EAJBb4a5wV+wCceLvxmup7pWXCVJzLvPTRLIZYiofMi5wwD0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 11:43:37.9962 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor It was used just to sanity check some obscure cases that are unlikely to ever happen. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index 5ac373c..cc20dc4 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c @@ -77,9 +77,6 @@ static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv) struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(drv); bool found = false; - if (WARN_ON(!fsl_mc_bus_exists())) - goto out; - if (!mc_drv->match_id_table) goto out; @@ -149,8 +146,6 @@ struct bus_type fsl_mc_bus_type = { }; EXPORT_SYMBOL_GPL(fsl_mc_bus_type); -static atomic_t root_dprc_count = ATOMIC_INIT(0); - static int fsl_mc_driver_probe(struct device *dev) { struct fsl_mc_driver *mc_drv; @@ -246,15 +241,6 @@ void fsl_mc_driver_unregister(struct fsl_mc_driver *mc_driver) EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister); /** - * fsl_mc_bus_exists - check if a root dprc exists - */ -bool fsl_mc_bus_exists(void) -{ - return atomic_read(&root_dprc_count) > 0; -} -EXPORT_SYMBOL_GPL(fsl_mc_bus_exists); - -/** * fsl_mc_get_root_dprc - function to traverse to the root dprc */ void fsl_mc_get_root_dprc(struct device *dev, @@ -506,8 +492,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, } mc_io2 = mc_io; - - atomic_inc(&root_dprc_count); } error = get_dprc_icid(mc_io2, obj_desc->id, &mc_dev->icid); @@ -588,17 +572,9 @@ void fsl_mc_device_remove(struct fsl_mc_device *mc_dev) device_del(&mc_dev->dev); put_device(&mc_dev->dev); - if (strcmp(mc_dev->obj_desc.type, "dprc") == 0) { + if (strcmp(mc_dev->obj_desc.type, "dprc") == 0) mc_bus = to_fsl_mc_bus(mc_dev); - if (fsl_mc_is_root_dprc(&mc_dev->dev)) { - if (atomic_read(&root_dprc_count) > 0) - atomic_dec(&root_dprc_count); - else - WARN_ON(1); - } - } - if (mc_bus) devm_kfree(mc_dev->dev.parent, mc_bus); else -- 1.8.3.1