From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbdBALns (ORCPT ); Wed, 1 Feb 2017 06:43:48 -0500 Received: from mail-dm3nam03on0077.outbound.protection.outlook.com ([104.47.41.77]:40000 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751716AbdBALnp (ORCPT ); Wed, 1 Feb 2017 06:43:45 -0500 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;nxp.com; dkim=none (message not signed) header.d=none; From: To: CC: , , , , , , , , , , , Laurentiu Tudor Subject: [PATCH 2/9] staging: fsl-mc: fix device ref counting Date: Wed, 1 Feb 2017 05:43:22 -0600 Message-ID: <20170201114329.21276-3-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170201114329.21276-1-laurentiu.tudor@nxp.com> References: <20170201114329.21276-1-laurentiu.tudor@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131304230182884565;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(336005)(39400400002)(39410400002)(39840400002)(39850400002)(39450400003)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(8936002)(81166006)(4326007)(81156014)(50466002)(2876002)(106466001)(626004)(50986999)(104016004)(86362001)(1076002)(305945005)(2351001)(68736007)(8676002)(5003940100001)(38730400001)(76176999)(54906002)(48376002)(2906002)(92566002)(86152003)(189998001)(6666003)(77096006)(47776003)(2950100002)(6916009)(33646002)(8656002)(85426001)(97736004)(105606002)(7416002)(36756003)(5660300001)(50226002)(53936002)(356003)(110136003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR03MB2531;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD010;1:c0XxRbfqIVMA62l12f/YSKDbazWNw4PwyRd+SQuM8JjxuSYP7KgxgP5nWiMu1r8u1nf2TjDankntzlc+mcbchXnn2Fcju0IzMhzXG860bIDI4zbwirtLAyJ8QLJi4PE3vaGrDw2M36dEH+LPPUoEbZ+4nFqvJHbFtb0xpwLMbS4yPVJfL1HHb3V4BvQwrXpfnRncrNeb6pnIDi56iviGmtaPprybV/wXFa9u3xP2X9TIoRNgFnTlQ7JtTdr8KnLTIvIEpoMeQbYG0Aj5i+GANCGuzHP9Kml46Gj5kUP+fTdn/RPIJZN0EQ7DyEjd1Px9UmE8txRaJ3mrI/nObQeu9rMZavnIuKcdwoRyocmI25FUA5rmMgSEbqzSj/EtANvZj2ifliImpWxNCsXS3OFrk6DN1lJ6arDpM8+FZ7RgcNqnkD4A6xj/FBNyt/AQUxljnF+Ozx1DidSbBuWj01+8OxmUC6K1PeDamBFpedlORoAfAPvO9UQHF0k9Q31VYaV7hiV38rUx5fUaK/ufswEA/aGsb1DVxYs/LPWlrTTSHBid/nwvHfOZRWLFrgWlC1fJRTG6CQm003KceTlTNvYolktHqqh06Mo+QaemUcKg00y5MfPfPDlDQGvYerKAbPxVkVjae2kq9CMKifShZOhwLF4quvHyaODQy0/vvDxaHT6by2S/yqy2CjNphYyvh9ARauqRJ9spxwVLGqRHUvvyFQ== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 92a1f637-2e68-4ea5-287e-08d44a978ff0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2531; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;3:QZ975986tF9lLwwKs3TU6+lrLDBqdrZS4vMBBfn9VrECsaZpZ1QpWV+lZ3xRtCJ2nJ8ZMBzQmUhhio6y760y3EXvW05VsQsFbu9Nnz8LX2yhaPO1hQjoBdzop0OffrLok0Gi5kPDcyX8CQEsfEMfFkc9YlwaMf8g4budsUpaCnIIGtfz/JuGdmJzGmZtNkr4Z55lgSAVOY9A7z8vWzgtvgqRjQl8w+4DlaJdh/w+poCy6iEuj/TqOBWlV2hN9ODau68o7z/bt71KHoZcki9jZ+rYT0g+pAgezVXyYkE9QC5odp57E10zaOiHs5y8tS3n9Oe4eXylWX0UMGU0QWyQmImFdmr0jeay/fWXzsjZ5LBagL8BDFvZU5w4WkHki9Tq X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;25:faylBnU7xXIchILlLsD82g88PzkZwHKLpbK4CkTT9kt4+coPc8hvdZssR0aiwfkiAsECSZYJkU7XuKJ1xuqdw1TVtf60TQOt+/BSte3niCwReWGNjcgWUf9asND9ePvrLwMXoPvf3FO1+BkwplBB2ch/I5r4uGLeucMSnufzDQkG0078Pyy3abvHZvFBPAiHkDHW9TS7u7wN2qrzzqJ778zUDtX6n+yeK25C8RYNcK1eQKpOuUY8eet1Pdt2EnOmeKHFUs+iNl1COoGeHfq1iEFznJ0l1psbQfBC3/A8v5JZSKGF3t9rjVHVIbe2+jeW+fCM5QOo9zrP/Ia89fxBdJrrdYC5l9kZev4zFsmpdjGUUzcoFesKOdY7eD+TVhPLmgTpPHm5lKonwYMCQDTQFjXrlxjr7Payvs290UhL41bjIr4SkLuD2DSif7RHPnPLuh4cYQgeC/jHafvykYgZJEFfopBlaVnzjLeVigISdUmqft34yNJLynT93+QMkmFfpYtSB85Bfp3oFHJYorRKscvbsjtJbz3ypO4A33e9qD9G3g+e5CWZZ+Wr+RiKrBTn93OV/4APhxshQXflwisvgA4/H5czGd0a0oHmPlgROFjt4shcDdYIX7c4JAQ5k5v02C79tpQ8Jw5dIO44VxEUKbaGu8sdGYrVtEyCEyVZZeTlOaNKXFDvvaJ0+XOdCZPYvfusmhhon50D0CQxQXo9RQ== X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;31:cRZl43plZPdMNG2b5IHXh4eAB5yCRmzeZ7irz5qdvUBe28Xj5F83jQt3Yx67gYNjoPaDPcDGQjGqMUhDVaTxpspzwo8NNYFVOiQZzHVUnFvmBi70fKvENftbkPQMqsMGpBc0klDka41jvoIIAV2WGZmbtEFKvwVnx44LwhsSzTkCbriK0IqAtLw/HTIGNUpqQoxZFgK8ZcapQ7snTjWVj7SZgFks3Noa4rRi3r13S77CbuTVUft+4vqdnaCH/1Gms3v4jFBVxLketX57/mApEg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123561025)(20161123559025)(20161123556025)(20161123563025);SRVR:BN6PR03MB2531;BCL:0;PCL:0;RULEID:(400006);SRVR:BN6PR03MB2531; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;4:8D/noE9Z/cNl55M8IW7Uh7YIVdsxDcGnWlxE6Rxe57i1eAf3GYLoWADWkCPCVIJ4cD0wX70vkeK0fYN6k9RkBsVJgjMC0yHxIB5zZ5TVZxeMMcx66N+YD8OAWhhPKpp0c7CtfH/PAJLACRuCPV7we5E7jsqtD6MZomklSic10oEm4mKj9pVh7kBVoGdGC6bQ7JBxW9+TEaLtG4kMSIdD8+GzG54yTFgBwL365BrS//4SX6FREfAuoK0xag5m0LI5XJcVeW9upKj+euvfJY+gXfKB9YcDhdRFbnHUjjIWIPsfmEpwVzxFpnq+vv5EPkofZ3lttSuACOPYMPU13PqhynrZHYkXQMlFxGWY1FPNvpMG4rZZBXt1/8QhVq45TyR9KaNGplUyC0Z7tOC1ABrvHZ0SoaEmbhKClqfNtV0WQKd8f5S+imrLZQGuYA5KhLt7pkYmS6URT7QzswWPWiKQjUzk+JMT9wkFoTdAv7Ewq+3DfqkoYngPHEABQyiXvjl6gRXEZzBj1yChaIOeGuMVawIlJ82RrxFsrj8b9ldQtyAfPYxXufCUO4pUSKziSVuTpc+IOwXGfCSdDG0dOYzvggiUsoBpvRX6kghpfCccqGXDLnHImgMEmugpCeBdBPsG8jyB1jJPt4iAqKGhTF+eMWvnHcobEpR0470KCKuz8tHQm4FmUl2s9QuBwac94gDtdgXARDHv1AqxL3eLXetkcuYcKC9aSA9cAZLMUGuJporyAsKb+65lrn35BG7eAFL5 X-Forefront-PRVS: 0205EDCD76 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR03MB2531;23:JtqqZ65F8j2zNxtlkmy3H4p0bdKMCbbsJmj7fCMdT?= =?us-ascii?Q?dUw8zaBapwkYY34TMTmGodxiEM5c79wQI3WNhpIwZiYLQUgYX9sKKhyiXfXn?= =?us-ascii?Q?578Kfe906SZtLvbz7GmaUrE3qtR6z3OigI+DhY8/qQEB+bry37NPQdM3gNd8?= =?us-ascii?Q?bHJpxqps60IvWY6rwx0ChpGZTR6vaX8f73UBBrQY3dBdF8DcaecLteUR3grc?= =?us-ascii?Q?sm2lo06zMDmAS8S2KeyOnrafAXV4IVbIVCqJ3DCiqeLz62wZOtzNZTfbNBEb?= =?us-ascii?Q?gIwmH7a7QU3naM1MCBQdqJuw4ZClmEDZxMj6feJu+Hgu8ZHckLFlNK4pSsp9?= =?us-ascii?Q?ntViNJ0YUEa4jEVQ0EHzt92H88iKVI2REM5T5YzoW/Cp/kgsrIULP4lVEUvd?= =?us-ascii?Q?FmQ1fIgpcGhxqEtgOIPYyyw1Whe4KgVdIhfZG7viob/XEksnGazcouTDOu9Q?= =?us-ascii?Q?lUCSB20DTZvigEkD8vP555ROF2KzwflAhoa5MwW9RGpYtxxiVPzYBv7fZglE?= =?us-ascii?Q?vBWK6HwUXcSB331c6bW0MHBoAssFcdddUIH/92sXyY6Vlkt8gLMr6rkif1Xn?= =?us-ascii?Q?uqfR/vxG5X6YSJAs16HhjFfLBj7wmjworudZAZpbjQxFAsDrAWqW9/4qU3C+?= =?us-ascii?Q?XXqNguCrKM5u8cVDIealUwflycfrj3lIIqmdlvIYbcsZW3xpvoKT8V8GgKjv?= =?us-ascii?Q?HQaN2EzyDCzildbcX3Uqp3Gpn3gd9r4GQlVzob21s1qjE7885MkIIBKRrzAG?= =?us-ascii?Q?8ukDxXtb8TsdnJi9EZqWFmZ6RtKV/vTu7i4VW5HYcDwU48HuA98qjmiQ0R3A?= =?us-ascii?Q?YINoMsFf7B1d4xuS8iF77IPEPR2yGrvrqDyPEocj9mqrlHGpVvINEWmB/O3m?= =?us-ascii?Q?JP3R10r/Bn0UQl0k3RfwkeMXi4i4iqNEhKxHAnBYlj0gGQpmAE6fqgEAgjZ9?= =?us-ascii?Q?OPfz0RNNmjbaCbMR/OtnCBo0Kzb7liUMQb2ouBMYvHaDoAPbdIiZ2RQHKLGS?= =?us-ascii?Q?VNoto9EeeeUk/c2FuGN8356lnnFjq3fpQWSpi+eDcd4Nq03VixMA6c5ubsRU?= =?us-ascii?Q?rzun9C0YMo7reTwgLyJAABNpCBkwW2hFGa5SpffEpHgBB9n5WKAgcVvXDkTc?= =?us-ascii?Q?jB3RdZBx+dh48ugdieiolmOFE4EyWTPerBNkv5UyJWI4D10383TSIf7me7qV?= =?us-ascii?Q?DZfrBt4LZUnkTtz7HKxx6JoL2pXR4dPKz05bK1rM7+fzoHbyfWRCWjQ01h2J?= =?us-ascii?Q?N3x5jWgZSAr3fqIfY4MGN6rhs7tdRW5tcHczXnniKsElEiHvsoc2jBpDs1HD?= =?us-ascii?Q?qGO1vHlOavr76qAHgY2Ga+Eir6QD83T+iofJUodm0EBFgJLH3C7fKKG8c+Yx?= =?us-ascii?Q?QHJa10eEiyw2iHUnJO1WTkoHbg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;6:Ng/jLXF9MKnmLexqHDyYsaqwLXLlRMtIZa5zdiErZkQM9SaKzBmMA9DOv59+xTvNZ/zRYIxfzGv5HZmERg62+SL25l6fmiQ7Lb/BVU0Sgb0MRjqC4hpfWcvBEw8kFpTFq71sWwjtNbENfWhNGIhnwLLlSIcNICON8d2I/pbsFXBMITjoddMM+h1tte2nuHaM7U95T0104qVlzc/mIGfkUoz09tg3AOIEJBsnHt51JxGQ9hUPyIq2ICy0fmWX6cbVjnd2vq2+15Wz0TOPnkgt0U02fREIvD3zXRx2cUZxj2QPLyeLgtyONav36eID9FCoSBTEoiwd2SwYnvG8fLlsHMlXLmz/AkNRlezKUUKfAlO+IVdpNoP7iFVcF1QPg1VgR7M9VOCCwwkFJx5J9XGmQVYlYij7wRz6YTvMHCqDApwS1uk5ThLek44V6YEwFcg4;5:8N0sVUbsqx9k3+slJdgfm5l6mPYWw5uxuElAUX75WHXipx7EXlPgZaLdCV5RL9zcOHJdQVZiL5PzV2+XXLa4fyENHZbT15i06e1fZOtucGpC5N6P08xm473tTLKpYa2phCxn0p2vE4LZG5sJc+rAeDJULQHKLkd/D1EwLtDaagPhlLeFEQeFjAa2q3Urxs/M;24:LFxra5PncixHdHeAr/d/nTX7820c1FW5kqqRhWSDfB/erU2UvR6pOfVE9NYpcfYiIpgmOiJO2QTi027TI90sD9HZnP6dKEFxqj16ogrL4wQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2531;7:iAPu4Xj3LOrgaHezBeJljtRrGFLJiG2o9FqXG08/9Rh2t2HDel6NtWo4GXiQ/aj+E5Kz4LkBPUKQdaCP0/vtjXfMto0GFyL7zt5Ucd2D3g08rMPVCVrKir6UUSAKjj39uF8NiKXdGosoKNOr29gHrz7k0fpFmecO4EnRybIMsCVyqNWejVbw5O4/IDQ02UZLVXmAsWYL1BVQe2dh8BOcFLZCs3cLV2EVCwp97YYT9MZ+logCGsYNHe5VjYL0iiCeCoeFACCpgs2DyvGvBtsgvLzS2NoGo7vSj1zKv80TJ5oSNuGaD3vogNowssmKBe/vHfTlxw5yJcYvq1300viYbKabfUy02Gj3n7gkT6D8EXSCIZihzuxd0dBQylbSYmiD/o37bNdc2SYZ+4gH8LyMkuQBGh4dn6pdZM3n0fi3jevFzjeHbnOgR0TVBhl9grxaLIlC0D4tIzj3ulmza0GByxGsBUXj70ukMALrZmnWIknkccenQe68UYW9uCDtrLKEPgBr117mDQ8bSnGI/HmrnbdzySs5rgYIcd9VbRH3WcADG+hw+Y5fkkgka9qWIe6Y X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 11:43:37.9608 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2531 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor Drop unneeded get_device() call at device creation and, as per documentation, drop reference count after using device_find_child() return. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 1 + drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c index 4e416d8..e4b0341 100644 --- a/drivers/staging/fsl-mc/bus/dprc-driver.c +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c @@ -188,6 +188,7 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev, child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev); if (child_dev) { check_plugged_state_change(child_dev, obj_desc); + put_device(&child_dev->dev); continue; } diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index cc20dc4..7c6a43b 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c @@ -537,7 +537,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, goto error_cleanup_dev; } - (void)get_device(&mc_dev->dev); dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev)); *new_mc_dev = mc_dev; -- 1.8.3.1