From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbdBAWMP (ORCPT ); Wed, 1 Feb 2017 17:12:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41986 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753726AbdBAWMO (ORCPT ); Wed, 1 Feb 2017 17:12:14 -0500 Date: Wed, 1 Feb 2017 14:12:13 -0800 From: Andrew Morton To: Lokesh Vutla Cc: Al Viro , , Linux ARM Mailing List , Tero Kristo , Sekhar Nori , Nishanth Menon , Muralidharan Karicheri Subject: Re: [PATCH v3] initramfs: finish fput() before accessing any binary from initramfs Message-Id: <20170201141213.3cf81a7a3a771ac2b94e8d48@linux-foundation.org> In-Reply-To: <20170201140540.22051-1-lokeshvutla@ti.com> References: <20170201140540.22051-1-lokeshvutla@ti.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Feb 2017 19:35:40 +0530 Lokesh Vutla wrote: > commit 4a9d4b024a31 ("switch fput to task_work_add") implements a > schedule_work() for completing fput(), but did not guarantee calling > __fput() after unpacking initramfs. Because of this, there is a > possibility that during boot a driver can see ETXTBSY when it tries > to load a binary from initramfs as fput() is still pending on that > binary. This patch makes sure that fput() is completed after unpacking > initramfs and removes the call to flush_delayed_fput() in kernel_init() > which happens very late after unpacking initramfs. There's not really enough info here for others to be able to decide which kernel versions need the fix. How serious is the bug? Given that it's been there for 4 years, I assume "not very"?