From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbdBAO5A (ORCPT ); Wed, 1 Feb 2017 09:57:00 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35758 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdBAO46 (ORCPT ); Wed, 1 Feb 2017 09:56:58 -0500 Date: Wed, 1 Feb 2017 14:56:54 +0000 From: Peter Griffin To: Lee Jones Cc: gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com Subject: Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines Message-ID: <20170201145654.GD28760@griffinp-ThinkPad-X1-Carbon-2nd> References: <20170201143145.31962-1-lee.jones@linaro.org> <20170201143145.31962-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201143145.31962-6-lee.jones@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Feb 2017, Lee Jones wrote: > The initial binding 'st,hw-flow-control' isn't used anywhere, in neither > in upstream nor downstream kernels. It isn't even documented in > dt-bindings, so we can safely assume it's safe to swap to the generic > one. > > Signed-off-by: Lee Jones Acked-by: Peter Griffin > --- > drivers/tty/serial/st-asc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c > index e521078..bcf1d33 100644 > --- a/drivers/tty/serial/st-asc.c > +++ b/drivers/tty/serial/st-asc.c > @@ -794,7 +794,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev) > return NULL; > > asc_ports[id].hw_flow_control = of_property_read_bool(np, > - "st,hw-flow-control"); > + "uart-has-rtscts"); > asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1"); > asc_ports[id].port.line = id; > asc_ports[id].rts = NULL;