From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbdBAP74 (ORCPT ); Wed, 1 Feb 2017 10:59:56 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:65314 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdBAP7z (ORCPT ); Wed, 1 Feb 2017 10:59:55 -0500 From: Arnd Bergmann To: Alex Deucher Cc: Arnd Bergmann , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Chunming Zhou , Flora Cui , =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Nicolai=20H=C3=A4hnle?= , Junwei Zhang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: shut up #warning for compile testing Date: Wed, 1 Feb 2017 16:59:21 +0100 Message-Id: <20170201155943.1740947-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:YcKfBQ+owp98O6yMr3A2ecl/8InjObISzqG8aT6F3gl+yp+c5wi 35So2a9SpBoWG0uCiTYYoALDQ4/45PTe05SdIM9D8iB7C6nd8fgBwAcZ/Pkvz3JdooMn1fA ufoC34N2cO4Cut806QreFU08vIRka7WB9KXhLPy+t3FULnr5aCcHwKtkcYHSz2lKrao/QVA umeNojK5oDSuC4zFszIaQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:O4yAulUa6RE=:iEk79r4ZmyOYwQUtJ2ubLk eRpWfBNA8SqcuzmzIxX+c2uFnA/2C96+RDv9ly6upyZU4EocUY2FBY7uAQ20+YAoy7kFDh78W hFl2ierOhOFLV33udpbaYRz7iz4LUDON2O1CNW0ieoijwSZLF4dT2eji2YreSu0CvvgA1gvYl tE11x8si+j9t1Aj1Ot8TMErfCmksEiTLAv2kMvoXF4YEaG/XFpSZDV2kqSfJz2U5k/UKlaSvl 3WJExsGRR6WtFQFrJOh1oreLld+ow0y60Yp82IsweLZl2FOePuDJT08FsNjbPss8a4vFsnpf2 57ZgeI+5E6T4MrxzMJimGqfFJm6s780gc5RVVcw0VwcuVt4b+yJoRRR9GRuxL8PRU1YBpgAst wR+52UwXI5fl9H8EkKpQESkrDlgin3gdrBmWLLCW+K7HyEMiyW8NRJ2ACCGlkuIuRsIegkab9 xgA1IQEnsBSwXf/VDZpy2Ig6pEqzz1yCs5hCcgO9B/+XsX3V7JXvhUlTY4/QdBH0JjJDGmTVz QlK15h2PqNKh/ob2/M5KF0tHQhj/lWlux29J5AZ2KZ4GSs4j3Cuk3qT8l5i7kwnMIWKFaxa5z JdzWIqhcD5cIrAQJTIeMCq0uomNylySfh8c94aDN7nXLphb58a5qybrr33W25tpZE8Q1FoqQ3 3v7fUkfPcnjuG1SPCgVsyQ6Zhr3J8OWQzDCsHI7DSvVOVf2HE5nzajfl+ZtpiE3/rTyA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My randconfig tests on linux-next showed a newly introduced warning: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted': drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:377:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Werror=cpp] Generally speaking, warnings about bad kernel configuration are not particularly helpful. We could enforce the selection of X86_PAT through Kconfig, so the driver cannot even be used unless it is enabled, or we could just rely on the runtime warning that is also there. In this version, I'm making the warning conditional on CONFIG_COMPILE_TEST, which shuts it up for me, but not people that may actually want to run the kernel as a compromize. Fixes: a2e2f29970aa ("drm/amdgpu: Bring bo creation in line with radeon driver (v2)") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index d1aa291b2638..da3a53a39d0b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -374,8 +374,10 @@ int amdgpu_bo_create_restricted(struct amdgpu_device *adev, * See https://bugs.freedesktop.org/show_bug.cgi?id=88758 */ +#ifndef CONFIG_COMPILE_TEST #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \ thanks to write-combining +#endif if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC) DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for " -- 2.9.0