From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbdBAQJ6 (ORCPT ); Wed, 1 Feb 2017 11:09:58 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54631 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbdBAQJ5 (ORCPT ); Wed, 1 Feb 2017 11:09:57 -0500 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Rob Herring , Stephen Boyd , Arnd Bergmann , Felipe Balbi , Guenter Roeck , linux-kernel@vger.kernel.org Subject: [PATCH] phy: qcom-usb-hs: add extcon dependency Date: Wed, 1 Feb 2017 17:08:55 +0100 Message-Id: <20170201160917.1984877-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:vUm86bRDaL9K8oZoS4Z8SpNsrZ9248idTOKGtRL5dfdW7GKeQlT iL/sumzx20cRUr5KInZlckOcZTNjQQUL0oyccaJelqPV3dIUWfIQemQe02Q+/Y5A58AyYTG avDv1Y0Lc4QbByNtPmHuL0q8KokcazrY5n/lNQihyO9J6aVXyslIAxwhCKKrQc3x3LBMEQq f5rOYk8P61/kliE4ADqsg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0qBX6VHT/Zg=:qn6wATXW+EZyx+EmL/0bdv bslFJL+3xkhzKlpltRkC2ftDfo9P5L2YdZXTatMnfnC42aODpMe31r6te2lzgAy6zzBdxVXMS tJYPD4n7lqG5o++n85HCBptKfZ5b2d9+1Oq20LS7BI7d6atdBlnz7GbuPwCGov0tPjbzhMXr2 b659N6+fzIE+ZQmd23hzZJXG9pQQaowJgPG0+WuYhqteLsPiUwk/5Dj6qOP3pB/r6mloT3CxO mzLD9gTtp1HyONgY68vlq43B4Rp4KcEH5joOX6+URwiXGWoNN1gASoPY2zhHAGozrp9liKLqd Ny/BRw75gmRx9TFYmdMGEnuzOekkJkRd9BnMts89Dbxss0kaRkFhLxot2hnSqvfbDWCKJXHGb cd9XtiKwdCk13DMLFWAAg4Xo0I27JLCHr1NA+FFuQ+YPkpd8fHRBpvOC/ULjup6f1EWWUPflJ zQ7rk6BvekswNwu+W8vzERZh9WkWJa2CH6cHPDBCb0IrRT/uSnb2jZrw0pBml+qsYZmMYTJbj JdcNRW5kmwUcZLm7ivp5gqCmEWzSCswZkBr0PJQcVy1AzJ2+fOQjBYG6ulq+WSC+U2Eo0u+uk Ga3jWJ3MayFL9kV5j8G4dNjzRhZXjcl+nNNro3JEywb9VmzBJkBFUzkFEKhzqkGhTDaIzt1/I kp30YUAjkSQ1/bwYehtwI+Vba5/2rp1BmlbPeRU7RkSpT8dOfyLAw3VMt3MvqmF2YKCE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If extcon is a loadable module and qcom-usb-hs is built-in, we get a link failure: drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_power_off': phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_off+0x24): undefined reference to `extcon_unregister_notifier' drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_power_on': phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_on+0x1a0): undefined reference to `extcon_get_state' phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_on+0x1cc): undefined reference to `extcon_register_notifier' drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_probe': phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_probe+0x15c): undefined reference to `extcon_get_edev_by_phandle' Adding a hard dependency avoids the problem. Alternatively we could use "depends on EXTCON || !EXTCON" to allow building with extcon disabled completely, but the other PHY drivers with extcon support also just have a dependency, so this is more consistent. Fixes: e2427b09ba92 ("phy: Add support for Qualcomm's USB HS phy") Signed-off-by: Arnd Bergmann --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 75907ecbef09..87c581f11297 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -443,6 +443,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" + depends on EXTCON depends on USB_ULPI_BUS select GENERIC_PHY help -- 2.9.0