From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbdBAQnp (ORCPT ); Wed, 1 Feb 2017 11:43:45 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57158 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbdBAQnm (ORCPT ); Wed, 1 Feb 2017 11:43:42 -0500 From: Arnd Bergmann To: Felipe Balbi Cc: Arnd Bergmann , Nicolas Ferre , Greg Kroah-Hartman , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: udc: atmel: fix debug output Date: Wed, 1 Feb 2017 17:41:55 +0100 Message-Id: <20170201164218.2421617-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:i1X8XEOWpK19SuEoUwTjZ2xlfiWv5t4dhIRKiI+ZlBiCWb6Z2u+ NUp9Sz268zkhmmmQnFIIcLXRlQxVWqmmOVsvsR3CQptWdXDe8JQHwen8R05AMrSB7eYkrsa C4pv2Z5fYuY9tIm4agspym7eZpI4bzwwIp2528ok86BU89+Di1A0DOoOVdV9KGdz8+13OuL /l2XFan2jk0ZWn9XUHxSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/noubAViVew=:a/HuyecYR++LuJsjZnWZC7 PXHG4pUItJTB4XYD0+U3BxJCkYCX2uF95D9ggp7LvFLfyJs48QXYLyCIcCLjT3+Nc59ZivBcX nwZScUYvr1Us5FaN9vEop1goGgHy3nH3FEKhr9QhCmPvbyA7o3Png6QcGGqhzwq97QaTsvnqB EQPwF6SrO+we4gd5p32rLG8BCpBm521VswM2tRRpAko0cCCfFr5g7GDUj8WJg5VFA1H8EzvSe oMOAb4LKkYIH/Oy/85oljXGRRT0FuVanYLdiaZnTBQhZJEvOtULOgcvFSKfW6u9nQW7jKc810 dngnVykBBr5D5Xtv2d8zPiF6ldAxc7lT1JdOKG5Sfl0li8gZAKEFu7K5aEgyOCp3QpiXqUtoh pWNEg2cggm4UT+ll5jWjAPVWsrCq4eGMo6MXvI4yO9xSTn5mgrgh2wc8kxzkCKJB0I5y+eLI2 LmaIFTccNMcK2FtaFOWljMBBOajoOeWVf9ilg6JLV/0wxhu+MlIkp+LHcRR+clV/XcZT3Jvxe DOdIGR6sQbudbAyUPMVU/mDUKJ7yrc77awLtDgnWtvpJqCdVuxlNi+vPxlQ/hN6QwE7HibDBi U8ZJRxjPJDwxgu4KK7rDLIF0iUT+yCxyEX+a+daoPygmlGTTQ9cKsIzfBmuv/rORy7tF0PDQ+ QD6X0WEdGwaNSLqgjLoTnl2dhwEinxWKUZCDzXGjp2NMTHFX+lLRMcUqSUWgp66OnzZs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The debug output now contains the wrong variable, as seen from the compiler warning: drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable': drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 11bbce28bc23..2035906b8ced 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { struct usba_ep *ep = to_usba_ep(_ep); struct usba_udc *udc = ep->udc; - unsigned long flags, ept_cfg, maxpacket; + unsigned long flags, maxpacket; unsigned int nr_trans; DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc); @@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) ep->is_in = 0; DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", - ep->ep.name, ept_cfg, maxpacket); + ep->ep.name, ep->ept_cfg, maxpacket); if (usb_endpoint_dir_in(desc)) { ep->is_in = 1; -- 2.9.0