From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbdBARjH (ORCPT ); Wed, 1 Feb 2017 12:39:07 -0500 Received: from mail-bl2nam02on0062.outbound.protection.outlook.com ([104.47.38.62]:38123 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752928AbdBARjF (ORCPT ); Wed, 1 Feb 2017 12:39:05 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; From: Robert Richter To: Marc Zyngier CC: Thomas Gleixner , Jason Cooper , , Robert Richter , Subject: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Date: Wed, 1 Feb 2017 18:38:25 +0100 Message-ID: <20170201173833.12630-2-rrichter@cavium.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170201173833.12630-1-rrichter@cavium.com> References: <20170201173833.12630-1-rrichter@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [92.229.95.220] X-ClientProxiedBy: DB6PR1001CA0017.EURPRD10.PROD.OUTLOOK.COM (10.171.79.27) To BY2PR07MB2343.namprd07.prod.outlook.com (10.166.114.145) X-MS-Office365-Filtering-Correlation-Id: 5386e962-0e63-4142-e90f-08d44ac93685 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR07MB2343; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2343;3:6L1JPKQlrFezCpNwNGdjzeHcwCruDbTWj2J8dIY0e36ac0i4HESKd6fh20GQyDi0J/cDjZHMt8sz6LQRSPGXODAFG9kNj+i507Agj6N+5/RdW2KnIPdZ+5Q0x0naufwFzPqRXHrifc88IhziI/ttVMeFcSscVJcM869SdEiF/jSOsXSgB/YkBFZ/NkuK5OZmwwZ5uXL3qDci2be+Yj5MjnvzflTVI4qASpYGhJRQyGI9WPmvM/P/T9MDgaKtVHgB+sO/PWHzLUMSydB3hiloiw==;25:vsmncsW09h6DIG4oYTwy2ruiAOrKK7U4O5mT6tnN9mjCtpSoM4bN5MWJL/Zj+hDtlwYObpWiPSCbUclAjv2gslMbMyVaK01xmF+jPgCUyWzXYYaRWBcEbvBUO2gCWCkUOb3BWZIn5Iai1uhbvOJOMtPkSBjiWX8nIFAfGWl1GwbqvVV5hnghn7I4iVmoLj3EeOdXcqZjdNLdv31ubWT/7ySLUf6wc5laBhLPhqqWoywjvvGSbeXO2hCpZlnyAloyY2qapeZep1YYLFIcNtQdGrsSADzwALcblkt11iqpXL4RVoE+6csigj+qC5+tUNKxyv1awC8E6lLofukhcTDz0+XjQFyfXlXjbRiTTNw2+qmAZBpdWUsxyYDGHPYqiYQ2IuaVIOdpewwFIi5FZq5phw==;31:kQlr0k54d/q4LCXRdFJnnb0VpwOZjL7UDFyJEC7190n6Qoyvtlg+P1MkYMghqlOBCidXQcCyxLHVuoMbElCqdetlL8J57ga1L/HormnrOatThVBUF3ZbPMZgWcv3CEhdPIB2Cejk3xnf/p1KsLSRBhdnBMm1zhnZVTWqeVkz+C3nOldVF0/lxftpKSArISW9NkXB1dj9/f5Q9o8gm0V/Qlx0J0iFsoCpXB03rOSap+4= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2343;20:2RUISLvmznhCruBZUcFBE6SG5ndgx8PDtdbr+W+y4+/DZmxckdkxyIq/AGZzb9xtdQGPDJYBA4Dmyi5+WT4GzIhfflzaCGm5ALggk1ncoOcbD73nxQ2srfwWIN58vvU50tPHVdwbB+zZqASF2O8usfNF/IC9LM0RrZOr48sA8wute91xAyER5dC7LSFd4fHTUfxgD6GSp8cG8ATcQ92W4o2EaYs1AH3yx3NPbOQgvZdIAgxSSMaI2O2LUysKzF6BfA+hxxGVGZbQ/hkGsGvzpKiOKT+O012zvtFZeCbeN/o5bZya1hiUPsc2lHAMka1YqrxnYc98KFLiAynGEOXuzr2l+tfU4WJ6X08dneHMe1YHZ0WqHsXzJepw2MrE/jLbPfetDS2mBHDY4Vb2q26EmUAz/MKx3TCVbu+etOCrOveTCvlzbTHJxN3m16RVBurtcG/JQUEvfzTJjMWYIHKR/7i0vnGpnWQyu4rlp2DL3yORzjs1Ka01zcuZHoPeLysY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123558025)(20161123562025)(6072148);SRVR:BY2PR07MB2343;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB2343; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2343;4:WtwgcI4Z3VoF/lA3oTJ8lNHOEgsV0z1SLwoFHLM3Tv+FvAP4N54c/UjrEFSXvKUB0c+n/9tJnWZC0tQ6CRbakUWas0cf4Qx8s+KT1OJbkRR+nViYxbS9CC5K/JOSHzYhtnxj3kFSAflRqWydbjx9moBqQPulgS9caendST0QPnAz+J75809FdKlQyiL2+BJQhyytEHeKCl3SDyB9lwR7FE6+ZMJmyD+Ug01EpSKvxtEOOB0c5217wVJJJRJpx65OYsn8JIXGN45x2DxpXi4dP4dTNxLV47OzWSyx417sD4IZ6tjPTn6DRVFcXzTyJytVaxPpYKMjVn3i1xOInE9BPCaolJovwZbLX5GQcrKiVYos6Yrx6Gfz/qN1r2RppujA+ysDviT5PZuzZ/U3APboavfOvEiUEOLMas8496etBmvuyEAmaUpGWbVOQeX4T7UUIhbN5s7+//oWChVuywO4vNwEvVGFEWu/lEOefm5TcR+qdVSfOrCuS+Ifmj2r42u8wThdce4qSYOUchhGcFUjofUvIxpqZtdOo+4EwpHUmzI5xGndOsQIq6hPtdMi22G9Ap17PRBS9LY4GZK/h6LlmBB4/6javFvgW/WUukny9CY= X-Forefront-PRVS: 0205EDCD76 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(189002)(81156014)(81166006)(189998001)(5660300001)(110136003)(97736004)(6916009)(2950100002)(50226002)(6666003)(230783001)(106356001)(105586002)(101416001)(42186005)(66066001)(8676002)(33646002)(47776003)(305945005)(7736002)(38730400001)(6506006)(6486002)(76176999)(68736007)(6512007)(53936002)(54906002)(5003940100001)(25786008)(1076002)(3846002)(6116002)(2906002)(4326007)(48376002)(50466002)(92566002)(50986999)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB2343;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB2343;23:IU1L3jqfDCUr+LbPc3EUyA2fSnWmJuHZwiP1GixMG?= =?us-ascii?Q?V/CW+oNh1vjA+MjguqEzk8gZc+xHm1FQCm9Jsug7ZxOLKHE93guixqv57+F/?= =?us-ascii?Q?7zfKgdndt1Uo3z/sJN1mQOYmewIoPAAvVTtogPC0jVRlN2kQ6Ph/aiG+q3q4?= =?us-ascii?Q?501t9FRnay3BMR2VkO/YljexK7fCyuuHHuRtNLYJsut9mkG/lAN+eQOZBTIi?= =?us-ascii?Q?ocS74KDpKvDDIlzB74nUWUAXQlbt74HvpHNQ1Bmcv9uz7a3oJqzRJSuUgm1r?= =?us-ascii?Q?ym9RPbH5pQOjUWneoKL3gIEPFMUsuiwhh+4m/TJSE3uMxHMTy0/9BgwBf1FN?= =?us-ascii?Q?68DfaCdOl/DwcbmwbsG41fieGeAZy2BxWHP/4xsNGwrovTwZhEaIRL/Jc6uO?= =?us-ascii?Q?zn88TaYfzBcPHuaGoh67KQWJtf7oKVfM8Xs9/+QY9JsNTfe/+p8cPcYPgpSa?= =?us-ascii?Q?IGKtn6hMRPJPnhwyCYrhAMCTN0Fx9LOP79NP2rJlpU67UNM5hrj8W8ZP3019?= =?us-ascii?Q?LxaU0U6xEQ6t2yieCa3O6wf4NH9oRhd/Ts1tl3qIZiXfdV0DevNcLVVOB7Tk?= =?us-ascii?Q?LpynNwpobLZj50YvRFpWvNTsyWnGcIx/HysfbuarnFpr8eP5zQJ9s5/RsYzN?= =?us-ascii?Q?Faz8mXmhHzct4PnHkrJ/5aaZaFDLBZZLj2lAEhuIeKjnwZIaHeG/Aa6/tTOh?= =?us-ascii?Q?0m20YFtZXQrW3ThYclBFcbcKRRpLtP/2bH1dY233FJB/zMhE9pVhLyNk7Fus?= =?us-ascii?Q?V+nyJHsDue6GltpMdcjddBFjF5TO3g+KI8ro+sAAEEGkVKhlxAhcirE4Dvdr?= =?us-ascii?Q?IZVziIZ7/Utc14JwKaFnOr1lMWGBhTBoylUhx3HrHVa4aKxvkpJ9QUV7Xttl?= =?us-ascii?Q?cruyzo42rXDPCs4DBNXDme95FQfbMR1ZZ5Tzz40v6WdJiGoph+H6vg/FY2Tq?= =?us-ascii?Q?KQxRpGHhtEkqVtV1OO7jsWFIViTiKK0LOa2RGvixjy98WXjUJrHMY/HR58x1?= =?us-ascii?Q?hNBFcCeobLrrkKIbVB52/yy0O8epgnYysMC0efRRJPoECtHQPViz8t4SUeSI?= =?us-ascii?Q?yIq64pLT5UsBHwcOuL9DAKjI2undwe1CM9LAhj8pbp4GMGEgpo7/iohM7bj4?= =?us-ascii?Q?omB9/HL8w5xDKspbDUs6gYKcI/8c/bj?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2343;6:KSOqUzPhQ4DnM+5dX87wNZSmEJHGMjwToWx39ECML/29Nc3dBEcj/MFFw2jzGXhnOKgSYvOh8hGM46mNrtgUyadQmzrE+UvK6ysGO6UxZE0YXrXt2dRoht12kqm73uMybFbCOzWLjxFUdgkwCmvZqY4/avrE2p+OAANh82BG01ZNSJRvs8s2JCvc2+Wol31CC2AZOPQ3i2xRb/qxFGAM093HJ6K8llITiAPsW1Lnh+QyT5mANumCieLMyBjzU/1FVX+0GEfD+DqI/8/k2SSY6iVRA4GiujcUJ3dqRy647V5KBx3bPUtUZtLWbQ4xa1xZte6VWnOVW0B3hjyTA8DZ1XYW/s3W11I7D0/W+ncOQkIoGV1ZgGxgrtAd6Estlwc3oRS4qnn9TSO/O9xUuoRJpA==;5:u9m0iK3jBjeGICPmlK9jR4RqUN9qgtDcS1xGa3oZRhCqflGrP1LcRFbqMyuKLOTME26C3Lhasu9lhtC6SPToLwpDrmUJpdtyrBg1kRiRcPJrVHUb9xuWDk+tXKPWeY+JA68NiwCl6RFfwPct9G2aiw==;24:v/PgtQ7I/eA2ihqJojFrDQt2n0C7vDiHaRZLODXstezxBcnS/MNSsfYQkjwouIQJfpYDNcrZCGS8nM1LPtHWT+fEmVsn3pYsURBfyuilXVY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2343;7:IZmCaETpSRHZB22NFIM3jNQ9+nj8PRDRI3gefIB3MOfVdBhqQ1a0Wa8ZVltzunyaVB6NtEFNrrGnYewV9JTWeH5MZ+Q10c3MHN2OuPR5jXMNoCVnhYbhmEk/cA24i/kGWEU1tU7/dOYTV6G7w7NvsDZEw/5iq4OU0agVYWNYPoBW5cijY0jMCrhrim0EmSLl6aPHBLcBoVo28W9AhBYZpgRGILYaz2QYwL4xgDvXUvHbsWWVpA/cC31vlrgljt8aI3cww0QOQPV/bVCu0gWs7E2zsR0b4RkYxG6bVD1L56zJMapYd+9tLboXN89sYHO9iUhZs2DPERhYTHVEQ6VA/DS0h2qB7LKLCZSzvzzxQOVY751QbJpa4Z3/4pT6x+iY8uTbSKE25BqLKgdWEa5caYPp4udtCfslAEkSm3Qsfmyh91wCyMTYm/G0Q0JlLKDldLMLFWKqd2s+NklHvT5vSlid3oGcBkrPq84C0fhXPEcuS6mzMh3nypZPnWXLE/mP08ikrpmVTEFJRrQJwipCeQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 17:39:01.4157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB2343 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The its command buffer must be page aligned, but kzalloc() is not guaranteed to be (though it is mostly when allocating 64k). Use __get_free_pages() as this is used for other buffers as well. Signed-off-by: Robert Richter --- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 69b040f47d56..dce70f21a15d 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -1693,7 +1693,8 @@ static int __init its_probe_one(struct resource *res, its->ite_size = ((gic_read_typer(its_base + GITS_TYPER) >> 4) & 0xf) + 1; its->numa_node = numa_node; - its->cmd_base = kzalloc(ITS_CMD_QUEUE_SZ, GFP_KERNEL); + its->cmd_base = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, + get_order(ITS_CMD_QUEUE_SZ)); if (!its->cmd_base) { err = -ENOMEM; goto out_free_its; -- 2.11.0