From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbdBAVO5 (ORCPT ); Wed, 1 Feb 2017 16:14:57 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:52859 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbdBAVOz (ORCPT ); Wed, 1 Feb 2017 16:14:55 -0500 Date: Wed, 1 Feb 2017 22:14:40 +0100 From: Andrew Lunn To: Lukasz Majewski Cc: Florian Fainelli , Rob Herring , Mark Rutland , "David S. Miller" , Mugunthan V N , Karicheri Muralidharan , linux-kernel@vger.kernel.org, Eric Engestrom , netdev@vger.kernel.org, Kishon Vijay Abraham I , Grygorii Strashko , devicetree@vger.kernel.org Subject: Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver Message-ID: <20170201211440.GG7395@lunn.ch> References: <1485960215-5148-1-git-send-email-lukma@denx.de> <20170201171610.GC7395@lunn.ch> <2f3766f0-42df-6aab-dda1-14022c57fb30@gmail.com> <20170201220500.29d478aa@jawa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201220500.29d478aa@jawa> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We would need a tri-state device tree properly: > > 1. Not defined - do nothing > 2. Defined as 0 -> explicitly disable port mirroring > 3. Defined as 1 -> explicitly enable port mirriring > > The "net-phy-lane-swap" only fulfills points 1 and 3 above. > > In my use case I do need point 2. Looking at the datasheet, PORT_MIRROR_EN defaults to 0. So it seems reasonable to unconditionally set it to 0 when the PHY driver loads. Any device which needs a value of 1 can set "net-phy-lane-swap" Andrew