From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750949AbdBBB4g (ORCPT ); Wed, 1 Feb 2017 20:56:36 -0500 Received: from imap.thunk.org ([74.207.234.97]:36066 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdBBB4e (ORCPT ); Wed, 1 Feb 2017 20:56:34 -0500 Date: Wed, 1 Feb 2017 20:56:28 -0500 From: "Theodore Ts'o" To: Sahitya Tummala Cc: Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jbd2: Fix use after free in kjournald2() Message-ID: <20170202015628.xl3vtta466ikeve6@thunk.org> Mail-Followup-To: Theodore Ts'o , Sahitya Tummala , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1485970311-22014-1-git-send-email-stummala@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485970311-22014-1-git-send-email-stummala@codeaurora.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 11:01:51PM +0530, Sahitya Tummala wrote: > Below is the synchronization issue between unmount and kjournald2 > contexts, which results into use after free issue in kjournald2(). > Fix this issue by using journal->j_state_lock to synchronize the > wait_event() done in journal_kill_thread() and the wake_up() done > in kjournald2(). Thanks, applied. - Ted