From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750972AbdBBIBG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Feb 2017 03:01:06 -0500
Received: from mx2.suse.de ([195.135.220.15]:36211 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750808AbdBBIBF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Feb 2017 03:01:05 -0500
Date: Thu, 2 Feb 2017 09:00:57 +0100
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, namespace: do not delete namespace-id 0
Message-ID: <20170202080057.GA3629@linux-x5ow.site>
References: <148597412157.20990.8337801110453234119.stgit@dwillia2-desk3.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <148597412157.20990.8337801110453234119.stgit@dwillia2-desk3.amr.corp.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 01, 2017 at 10:35:21AM -0800, Dan Williams wrote:
> Given that the naming of pmem devices changes from the pmemX form to the
> pmemX.Y form when namespace id is greater than 0, arrange for namespaces
> with id-0 to be exempt from deletion. Otherwise a simple reconfiguration
> of an existing namespace to a new mode results in a name change of the
> resulting block device:
> 
>     # ndctl list --namespace=namespace1.0
>     {
>       "dev":"namespace1.0",
>       "mode":"raw",
>       "size":2147483648,
>       "uuid":"3dadf3dc-89b9-4b24-b20e-abc8a4707ce3",
>       "blockdev":"pmem1"
>     }
> 
>     # ndctl create-namespace --reconfig=namespace1.0 --mode=memory --force
>     {
>       "dev":"namespace1.1",
>       "mode":"memory",
>       "size":2111832064,
>       "uuid":"7b4a6341-7318-4219-a02c-fb57c0bbf613",
>       "blockdev":"pmem1.1"
>     }
> 
> This change does require tooling changes to explicitly look for
> namespaceX.0 if the seed has already advanced to another namespace.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 98a29c39dc68 ("libnvdimm, namespace: allow creation of multiple pmem-namespaces per region")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850