From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbdBBKpU (ORCPT ); Thu, 2 Feb 2017 05:45:20 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36483 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdBBKpS (ORCPT ); Thu, 2 Feb 2017 05:45:18 -0500 Date: Thu, 2 Feb 2017 11:45:14 +0100 From: Daniel Vetter To: Neil Armstrong Cc: airlied@linux.ie, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm Message-ID: <20170202104514.nogjnsuimeulml53@phenom.ffwll.local> Mail-Followup-To: Neil Armstrong , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1486028864-19622-1-git-send-email-narmstrong@baylibre.com> <1486028864-19622-3-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486028864-19622-3-git-send-email-narmstrong@baylibre.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote: > The platform driver name is currently "meson" which can lead to some > confusion, this patch renames it to "meson-drm" and removes the owner > attribute. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c > index ff1f601..380bde7 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev) > .probe = meson_drv_probe, > .remove = meson_drv_remove, > .driver = { > - .owner = THIS_MODULE, I don't get why you remove this, generally that will lead to trouble of being able to unload code that's still in use ... Otherwise ack. Now, do you want to get this landed as part of the small drivers in drm-mis experiment? -Daniel > - .name = DRIVER_NAME, > + .name = "meson-drm", > .of_match_table = dt_match, > }, > }; > -- > 1.9.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch