From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbdBBMQs (ORCPT ); Thu, 2 Feb 2017 07:16:48 -0500 Received: from mga09.intel.com ([134.134.136.24]:4968 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdBBMQo (ORCPT ); Thu, 2 Feb 2017 07:16:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="816222299" Date: Thu, 2 Feb 2017 14:16:39 +0200 From: Mika Westerberg To: Johannes Stezenbach Cc: Andy Shevchenko , "linux-acpi@vger.kernel.org" , Platform Driver , "linux-kernel@vger.kernel.org" , David Cohen , ramakrishna.pallala@intel.com Subject: Re: Cherryview wake up events Message-ID: <20170202121639.GO2053@lahna.fi.intel.com> References: <20170127113845.zt5jwjzumafclvzc@sig21.net> <20170127133058.pxuovuuqpnffx3py@sig21.net> <20170130205745.wwavipta5hbz5zfz@sig21.net> <20170131143740.lgn2svjskjulsucf@sig21.net> <20170202095200.d5clhprl7rpgrf72@sig21.net> <20170202103122.GH2053@lahna.fi.intel.com> <20170202111222.aoiwinw37jrquhbh@sig21.net> <20170202113508.GM2053@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170202113508.GM2053@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2017 at 01:35:08PM +0200, Mika Westerberg wrote: > On Thu, Feb 02, 2017 at 12:12:22PM +0100, Johannes Stezenbach wrote: > > On Thu, Feb 02, 2017 at 12:31:22PM +0200, Mika Westerberg wrote: > > > On Thu, Feb 02, 2017 at 10:52:00AM +0100, Johannes Stezenbach wrote: > > > > OperationRegion (GPOP, GeneralPurposeIo, Zero, 0x0100) > > > > Field (GPOP, ByteAcc, NoLock, Preserve) > > > > { > > > > Connection ( > > > > GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly, > > > > "\\_SB.PCI0.I2C7.PMI2", 0x00, ResourceConsumer, , > > > > ) > > > > { // Pin list > > > > 0x0020 > > > > } > > > > ), > > > > GMP0, 1, > > > > ... > > > > (repeat for many more pins) > > > > > > > > I guess it means it uses chv_gpio pins and can't work > > > > if the GPIO opregion is not registered? > > > > > > That is using GPIO pins of the PMI2 device - the PMIC GPIO driver, I > > > suppose. > > > > > > So in addition to the PMIC MFD driver, you need to have a GPIO driver > > > for Dollar Cove (I guess the quilt patch series included that as well?). > > > > Nope, I see it for AX288 but didn't find it for TI DCove. And in > > current Linus' tree axp288_cells[] doesn't include gpio so > > I concluded it's not needed... what am I missing? > > So reading your DSDT there is that GPIO button array device \_SB.TBAD > which has one GpioInt() referencing \_SB.PCI0.I2C7.PMI2. I suppose that > is the power button GPIO. > > In order to use that there needs to be a GPIO driver exposing those > GPIOs to other drivers. So it is definitely needed. Actually, looking again the patches you found: https://github.com/01org/ProductionKernelQuilts/blob/master/uefi/cht-m1stable/patches/mfd-intel_soc_pmic-add-TI-variant-of-dollar-cove.patch https://github.com/01org/ProductionKernelQuilts/blob/master/uefi/cht-m1stable/patches/PWRBTN-add-driver-for-TI-PMIC.patch Did you try to them both? The latter seems to handle the power button by talking directly with the PMIC (instead of using a GPIO). Let's include the original author (Ramakrishna) as well if we could get some information from him.