From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbdBBNL0 (ORCPT ); Thu, 2 Feb 2017 08:11:26 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:53350 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdBBNLY (ORCPT ); Thu, 2 Feb 2017 08:11:24 -0500 Date: Thu, 2 Feb 2017 14:11:12 +0100 From: Andrew Lunn To: Lukasz Majewski Cc: Florian Fainelli , Rob Herring , Mark Rutland , "David S. Miller" , Mugunthan V N , Karicheri Muralidharan , linux-kernel@vger.kernel.org, Eric Engestrom , netdev@vger.kernel.org, Kishon Vijay Abraham I , Grygorii Strashko , devicetree@vger.kernel.org Subject: Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver Message-ID: <20170202131112.GI4967@lunn.ch> References: <1485960215-5148-1-git-send-email-lukma@denx.de> <20170201171610.GC7395@lunn.ch> <2f3766f0-42df-6aab-dda1-14022c57fb30@gmail.com> <20170201220500.29d478aa@jawa> <20170201211440.GG7395@lunn.ch> <20170201231323.732dd327@jawa> <20170202015416.GG4967@lunn.ch> <20170202101739.67e7e6b3@jawa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170202101739.67e7e6b3@jawa> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The bootstrapping process in the PHY sets this bit. This is wrong since > the board lane layout is not "swapped" Ah, you mean a strapping pin? Resistor to ground/VCC? That is a different matter. It makes it a lot less likely to break some existing board with such a change. > I have thought a bit about that and I think that we should define > complementary "net-phy-lane-no-swap" as suggested by Florian. Then > affected boards could define it and use. This is the most flexible solution. Yes, that is O.K. for me. Andrew