From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbdBBSsZ (ORCPT ); Thu, 2 Feb 2017 13:48:25 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33749 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdBBSsW (ORCPT ); Thu, 2 Feb 2017 13:48:22 -0500 Date: Thu, 2 Feb 2017 13:48:14 -0500 From: Tejun Heo To: Li Zefan , Johannes Weiner Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH cgroup/for-4.11] cgroup: drop the matching uid requirement on migration for cgroup v2 Message-ID: <20170202184814.GB7917@htj.duckdns.org> References: <20170120162954.GA30978@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170120162954.GA30978@mtj.duckdns.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 11:29:54AM -0500, Tejun Heo wrote: > Along with the write access to the cgroup.procs or tasks file, cgroup > has required the writer's euid, unless root, to match [s]uid of the > target process or task. On cgroup v1, this is necessary because > there's nothing preventing a delegatee from pulling in tasks or > processes from all over the system. > > If a user has a cgroup subdirectory delegated to it, the user would > have write access to the cgroup.procs or tasks file. If there are no > further checks than file write access check, the user would be able to > pull processes from all over the system into its subhierarchy which is > clearly not the intended behavior. The matching [s]uid requirement > partially prevents this problem by allowing a delegatee to pull in the > processes that belongs to it. This isn't a sufficient protection > however, because a user would still be able to jump processes across > two disjoint sub-hierarchies that has been delegated to them. > > cgroup v2 resolves the issue by requiring the writer to have access to > the common ancestor of the cgroup.procs file of the source and target > cgroups. This confines each delegatee to their own sub-hierarchy > proper and bases all permission decisions on the cgroup filesystem > rather than having to pull in explicit uid matching. > > cgroup v2 has still been applying the matching [s]uid requirement just > for historical reasons. On cgroup2, the requirement doesn't serve any > purpose while unnecessarily complicating the permission model. Let's > drop it. > > Signed-off-by: Tejun Heo Applied to cgroup/for-4.11. Thanks. -- tejun