From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbdBCJvA (ORCPT ); Fri, 3 Feb 2017 04:51:00 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:54404 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbdBCJu6 (ORCPT ); Fri, 3 Feb 2017 04:50:58 -0500 From: Arnd Bergmann To: Brian Norris Cc: Arnd Bergmann , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy Date: Fri, 3 Feb 2017 10:49:17 +0100 Message-Id: <20170203094946.2112158-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Dj97PfPO5medOam0G+k5ok+qvjuxU04keLF7MPAWGra3prYUiPb Bo1t7x3NWvSujm3gDUbiGJcw/tzl2XYKLlvO+6j4Qp5LtApzrfOa9VAUAKqboqDEr5ZS+cW D8YEjOzlOBcVxCMquYlEjRJJ6Zng+z7NHJdUfBZbdTOgvvRkhbkegUf+Ets6MH4Q50yLzoE ugEyLO1Fe4CX/Q9kcplQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:c6Z6I3bzI+8=:ZAEMN6dDJcCjbayDpJLiSn 6BFFd3CPE2OtqgyJLzin50imkOiGXYdeauIY4sUi9YAQNpV3Jv6pLTbiFJWKyqaa0GQwTcoNo pH5v2lznzhDu/SP1FuvY1SGTlvaHaQenlcVQg84IwOzj8OLCAfrMwKGDLAJy70nFt7hDBSA7u Hjbq90rHfZFzszffDNe/706PTo1R98bEd6Sy2UUxPOAb3R4PQ3yS1y6A1NQ6aSvxcSw/0f9yl EW6PvYKL/QmYtxqFSHDcn2X1IdJ633HBzkNJ+7XVcfL4OFFIUkAOYmd7fLevmrqPZTx6K/l0M bSmed+Buc4TarRh3hrpmZM0s8tTNg72i83MenZFAYudtaFS0bqI1I+PkRPgavZnj3kjcCayKt hLHKJg0AvHRJbWVA1wz1P7KGRaqadPHhan4lgiJV+2aUbiViR0tPuppH7GELEGIfcADqJEtgP Svm7msL3JcXrb++Ttgkf/zutdh+M8+1OVCAbXw64sNAFKerZTTw2K1QG9yES1FAJ8Upnbjt4k qAIqULDxtGFr5dUS1cC1CjG4QFV8pDuDAGn3nPnksVbGOcgiwOcQh2ZlJLHbMVmKLzgADMC+S 4crBkz/dUoMyUgOwZmUMQ5RxMjVVcRrdBLoJyCK/bTTkit5HJ8drS/lylPpLJxI5Pa6l9MVkV 6VwKZXw4NRgVUpGISsaXOFlgZSVE12NOvSJiYI9mdRzZbz3OltB2Xc+f0izdYTq3Wexg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernelci.org reports a warning for this driver, as it copies a local variable into a 'const char *' string: drivers/mtd/maps/pmcmsp-flash.c:149:30: warning: passing argument 1 of 'strncpy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] Using kstrndup() simplifies the code and avoids the warning. Signed-off-by: Arnd Bergmann --- drivers/mtd/maps/pmcmsp-flash.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/maps/pmcmsp-flash.c b/drivers/mtd/maps/pmcmsp-flash.c index f9fa3fad728e..2051f28ddac6 100644 --- a/drivers/mtd/maps/pmcmsp-flash.c +++ b/drivers/mtd/maps/pmcmsp-flash.c @@ -139,15 +139,13 @@ static int __init init_msp_flash(void) } msp_maps[i].bankwidth = 1; - msp_maps[i].name = kmalloc(7, GFP_KERNEL); + msp_maps[i].name = kstrndup(flash_name, 7, GFP_KERNEL); if (!msp_maps[i].name) { iounmap(msp_maps[i].virt); kfree(msp_parts[i]); goto cleanup_loop; } - msp_maps[i].name = strncpy(msp_maps[i].name, flash_name, 7); - for (j = 0; j < pcnt; j++) { part_name[5] = '0' + i; part_name[7] = '0' + j; -- 2.9.0