From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbdBCOyR (ORCPT ); Fri, 3 Feb 2017 09:54:17 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34954 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdBCOyQ (ORCPT ); Fri, 3 Feb 2017 09:54:16 -0500 From: Zhengyi Shen To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging:most/hdm-i2c: Replace symbolic permissions with octal permissions Date: Fri, 3 Feb 2017 22:54:06 +0800 Message-Id: <20170203145406.12498-1-shenzhengyi@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. This warning was detected by checkpatch.pl for hdm_i2c.c. Signed-off-by: Zhengyi Shen --- drivers/staging/most/hdm-i2c/hdm_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-i2c/hdm_i2c.c b/drivers/staging/most/hdm-i2c/hdm_i2c.c index ba0263b..1d5b229 100644 --- a/drivers/staging/most/hdm-i2c/hdm_i2c.c +++ b/drivers/staging/most/hdm-i2c/hdm_i2c.c @@ -37,7 +37,7 @@ enum { CH_RX, CH_TX, NUM_CHANNELS }; /* IRQ / Polling option */ static bool polling_req; -module_param(polling_req, bool, S_IRUGO); +module_param(polling_req, bool, 0444); MODULE_PARM_DESC(polling_req, "Request Polling. Default = 0 (use irq)"); /* Polling Rate */ -- 2.9.3