From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751149AbdBCPPp (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Feb 2017 10:15:45 -0500
Received: from mx2.suse.de ([195.135.220.15]:36141 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751108AbdBCPPn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Feb 2017 10:15:43 -0500
Date: Fri, 3 Feb 2017 16:15:40 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: "'Johannes Weiner'" <hannes@cmpxchg.org>,
        "'Andrew Morton'" <akpm@linux-foundation.org>,
        "'Mel Gorman'" <mgorman@suse.de>,
        "'Minchan Kim'" <minchan.kim@gmail.com>,
        "'Rik van Riel'" <riel@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until
 they're flushed
Message-ID: <20170203151532.GE19325@dhcp22.suse.cz>
References: <20170202191957.22872-1-hannes@cmpxchg.org>
 <20170202191957.22872-7-hannes@cmpxchg.org>
 <006601d27df1$228a3940$679eabc0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <006601d27df1$228a3940$679eabc0$@alibaba-inc.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 03-02-17 15:42:55, Hillf Danton wrote:
> 
> On February 03, 2017 3:20 AM Johannes Weiner wrote: 
> > @@ -1063,7 +1063,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> >  			    PageReclaim(page) &&
> >  			    test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> >  				nr_immediate++;
> > -				goto keep_locked;
> > +				goto activate_locked;
> 
> Out of topic but relevant IMHO, I can't find where it is cleared by grepping:
> 
> $ grep -nr PGDAT_WRITEBACK  linux-4.9/mm
> linux-4.9/mm/vmscan.c:1019:	test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> linux-4.9/mm/vmscan.c:1777:	set_bit(PGDAT_WRITEBACK, &pgdat->flags);

I would just get rid of this flag.

-- 
Michal Hocko
SUSE Labs