From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbdBCUc5 (ORCPT ); Fri, 3 Feb 2017 15:32:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:36170 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbdBCUc4 (ORCPT ); Fri, 3 Feb 2017 15:32:56 -0500 Date: Fri, 3 Feb 2017 20:32:22 +0000 From: Mel Gorman To: "'Andrew Morton'" Cc: Hillf Danton , "'Johannes Weiner'" , "'Mel Gorman'" , "'Michal Hocko'" , "'Minchan Kim'" , "'Rik van Riel'" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm, vmscan: Clear PGDAT_WRITEBACK when zone is balanced Message-ID: <20170203203222.gq7hk66yc36lpgtb@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hillf Danton pointed out that since commit 1d82de618dd ("mm, vmscan: make kswapd reclaim in terms of nodes") that PGDAT_WRITEBACK is no longer cleared. It was not noticed as triggering it requires pages under writeback to cycle twice through the LRU and before kswapd gets stalled. Historically, such issues tended to occur on small machines writing heavily to slow storage such as a USB stick. Once kswapd stalls, direct reclaim stalls may be higher but due to the fact that memory pressure is requires, it would not be very noticable. Michal Hocko suggested removing the flag entirely but the conservative fix is to restore the intended PGDAT_WRITEBACK behaviour and clear the flag when a suitable zone is balanced. Signed-off-by: Mel Gorman --- mm/vmscan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 532a2a750952..3379fa5ce6d8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3103,6 +3103,7 @@ static bool zone_balanced(struct zone *zone, int order, int classzone_idx) */ clear_bit(PGDAT_CONGESTED, &zone->zone_pgdat->flags); clear_bit(PGDAT_DIRTY, &zone->zone_pgdat->flags); + clear_bit(PGDAT_WRITEBACK, &zone->zone_pgdat->flags); return true; } -- Mel Gorman SUSE Labs