From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdBEArT (ORCPT ); Sat, 4 Feb 2017 19:47:19 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:56192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbdBEArS (ORCPT ); Sat, 4 Feb 2017 19:47:18 -0500 Date: Sat, 04 Feb 2017 19:47:14 -0500 (EST) Message-Id: <20170204.194714.2295825542000326986.davem@davemloft.net> To: ross.lagerwall@citrix.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, linux-kernel@vger.kernel.org, wei.liu2@citrix.com Subject: Re: [PATCH] xen-netfront: Improve error handling during initialization From: David Miller In-Reply-To: <1485964222-1501-1-git-send-email-ross.lagerwall@citrix.com> References: <1485964222-1501-1-git-send-email-ross.lagerwall@citrix.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 04 Feb 2017 15:48:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ross Lagerwall Date: Wed, 1 Feb 2017 15:50:22 +0000 > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. setup_timer() doesn't do anything that must be "undone" if an error occurs and we have to cleanup. It just assigns some values to some timer struct fields, that's it. Therefore this change is extraneous and unnecessary.