From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbdBEKjm (ORCPT ); Sun, 5 Feb 2017 05:39:42 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41828 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbdBEKjl (ORCPT ); Sun, 5 Feb 2017 05:39:41 -0500 Date: Sun, 5 Feb 2017 11:39:43 +0100 From: Greg KH To: Youngdo Lee Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error Message-ID: <20170205103943.GA27540@kroah.com> References: <1486183368-31664-1-git-send-email-paul.ydlee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486183368-31664-1-git-send-email-paul.ydlee@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 04, 2017 at 01:42:48PM +0900, Youngdo Lee wrote: > Fix checkpatch error: > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Youngdo Lee > --- > drivers/staging/fbtft/fbtft-bus.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c > index ec45043..3ce265d 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c > @@ -10,6 +10,7 @@ > * > *****************************************************************************/ > > +#define nop_modifier(expr) (expr) What? > #define define_fbtft_write_reg(func, type, modifier) \ > void func(struct fbtft_par *par, int len, ...) \ > { \ > @@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \ > } \ > EXPORT_SYMBOL(func); > > -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) > +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier) That's really odd. Don't do crazy things like this to fix odd code. Fix up the code to not do such looney things in the first place. thanks, greg k-h