From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbdBEPoM (ORCPT ); Sun, 5 Feb 2017 10:44:12 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35389 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdBEPoK (ORCPT ); Sun, 5 Feb 2017 10:44:10 -0500 From: Wei Yongjun To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Cc: Wei Yongjun , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] lightnvm: fix possible memory leak in nvme_nvm_get_l2p_tbl() Date: Sun, 5 Feb 2017 15:44:00 +0000 Message-Id: <20170205154400.31336-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun 'entries' is malloced in nvme_nvm_get_l2p_tbl() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: 8e79b5cb1d3b ("lightnvm: move block provisioning to targets") Signed-off-by: Wei Yongjun --- drivers/nvme/host/lightnvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index 588d4a3..2388716 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -368,7 +368,8 @@ static int nvme_nvm_get_l2p_tbl(struct nvm_dev *nvmdev, u64 slba, u32 nlb, if (unlikely(elba > nvmdev->total_secs)) { pr_err("nvm: L2P data from device is out of bounds!\n"); - return -EINVAL; + ret = -EINVAL; + goto out; } /* Transform physical address to target address space */