From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbdBFGdC (ORCPT ); Mon, 6 Feb 2017 01:33:02 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:29319 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbdBFGdA (ORCPT ); Mon, 6 Feb 2017 01:33:00 -0500 Date: Mon, 6 Feb 2017 07:32:04 +0100 From: Willy Tarreau To: Bart Van Assche Cc: "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "sagig@mellanox.com" , "dledford@redhat.com" , "nab@linux-iscsi.org" Subject: Re: [PATCH 3.10 199/319] IB/srpt: Simplify srpt_handle_tsk_mgmt() Message-ID: <20170206063204.GB9533@1wt.eu> References: <1486322541-8206-1-git-send-email-w@1wt.eu> <1486322541-8206-100-git-send-email-w@1wt.eu> <1486358029.2980.1.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486358029.2980.1.camel@sandisk.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, On Mon, Feb 06, 2017 at 05:14:04AM +0000, Bart Van Assche wrote: > On Sun, 2017-02-05 at 20:20 +0100, Willy Tarreau wrote: > > From: Bart Van Assche > > > > commit 51093254bf879bc9ce96590400a87897c7498463 upstream. > > > > Let the target core check task existence instead of the SRP target > > driver. Additionally, let the target core check the validity of the > > task management request instead of the ib_srpt driver. > > > > This patch fixes the following kernel crash: > > > > BUG: unable to handle kernel NULL pointer dereference at 0000000000000001 > > IP: [] srpt_handle_new_iu+0x6d7/0x790 [ib_srpt] > > Oops: 0002 [#1] SMP > > Call Trace: > > [] srpt_process_completion+0xde/0x570 [ib_srpt] > > [] srpt_compl_thread+0x13f/0x160 [ib_srpt] > > [] kthread+0xcf/0xe0 > > [] ret_from_fork+0x7c/0xb0 > > Hi Willy, > > The first part of the description of this patch is correct (the part about > the refactoring) but the second part not (about the kernel crash). If you > are looking only for patches that fix bugs you may want to skip this patch. OK I'm dropping it then. Thanks! Willy