From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Linux API <linux-api@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ingo Molnar <mingo@redhat.com>, Paul Turner <pjt@google.com>,
Mike Galbraith <efault@gmx.de>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-team@fb.com, lvenanci@redhat.com
Subject: Re: [PATCHSET for-4.11] cgroup: implement cgroup v2 thread mode
Date: Mon, 6 Feb 2017 10:50:21 +0100 [thread overview]
Message-ID: <20170206095021.GI6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170202215229.GA27231@htj.duckdns.org>
On Thu, Feb 02, 2017 at 04:52:29PM -0500, Tejun Heo wrote:
> > Why do you need to manually turn it on? That is, couldn't it be
> > automatic based on what controllers are enabled?
>
> This came up already but it's not like some controllers are inherently
> thread-only. Consider CPU, all in-context CPU cycle consumptions are
> tied to the thread; however, we also want to be able to account for
> CPU cycles consumed for, for example, memory reclaim or encryption
> during writeback.
>
> I played with an interface where thread mode is enabled automatically
> upto the common ancestor of the threads but not only was it
> complicated to implement but also the eventual behavior was very
> confusing as the resource domain can change without any active actions
> from the user. I think keeping things simple is the right choice
> here.
Note that the explicit marking of the resource domains gets you exactly
that. But let me reply in the other subthread.
next prev parent reply other threads:[~2017-02-06 9:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 20:06 Tejun Heo
2017-02-02 20:06 ` [PATCH 1/5] cgroup: reorganize cgroup.procs / task write path Tejun Heo
2017-02-02 20:06 ` [PATCH 2/5] cgroup: add @flags to css_task_iter_start() and implement CSS_TASK_ITER_PROCS Tejun Heo
2017-02-02 20:06 ` [PATCH 3/5] cgroup: introduce cgroup->proc_cgrp and threaded css_set handling Tejun Heo
2017-02-02 20:06 ` [PATCH 4/5] cgroup: implement CSS_TASK_ITER_THREADED Tejun Heo
2017-02-02 20:06 ` [PATCH 5/5] cgroup: implement cgroup v2 thread support Tejun Heo
2017-02-02 21:32 ` [PATCHSET for-4.11] cgroup: implement cgroup v2 thread mode Andy Lutomirski
2017-02-02 21:52 ` Tejun Heo
2017-02-03 21:10 ` Andy Lutomirski
2017-02-03 21:56 ` Tejun Heo
2017-02-06 9:50 ` Peter Zijlstra [this message]
2017-02-03 20:20 ` Peter Zijlstra
2017-02-03 20:59 ` Tejun Heo
2017-02-06 12:49 ` Peter Zijlstra
2017-02-08 23:08 ` Tejun Heo
2017-02-09 10:29 ` Peter Zijlstra
2017-02-10 15:45 ` Tejun Heo
2017-02-10 17:51 ` Peter Zijlstra
2017-02-12 5:05 ` Tejun Heo
2017-02-12 6:59 ` Mike Galbraith
2017-02-13 5:45 ` Mike Galbraith
2017-03-13 19:26 ` Tejun Heo
2017-03-14 14:45 ` Mike Galbraith
2017-02-14 10:35 ` Peter Zijlstra
2017-03-13 20:05 ` Tejun Heo
2017-03-21 12:39 ` Peter Zijlstra
2017-03-22 14:52 ` Peter Zijlstra
2017-02-09 13:07 ` Paul Turner
2017-02-09 14:47 ` Peter Zijlstra
2017-02-09 15:08 ` Mike Galbraith
[not found] ` <CAPM31RJaJjFwenC36Abij+EdzO3KBm-DEjQ_crSmzrtrrn2N2A@mail.gmail.com>
2017-02-13 5:28 ` Mike Galbraith
2017-02-10 15:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206095021.GI6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=lvenanci@redhat.com \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome