From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbdBFLsx (ORCPT ); Mon, 6 Feb 2017 06:48:53 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36375 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbdBFLsw (ORCPT ); Mon, 6 Feb 2017 06:48:52 -0500 Date: Mon, 6 Feb 2017 09:48:48 -0200 From: Gustavo Padovan To: Wei Yongjun Cc: Marek Vasut , David Airlie , Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Message-ID: <20170206114848.GB28952@joana> Mail-Followup-To: Gustavo Padovan , Wei Yongjun , Marek Vasut , David Airlie , Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170205160036.7364-1-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170205160036.7364-1-weiyj.lk@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, 2017-02-05 Wei Yongjun : > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index cdfbe02..28a75cb 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) > mxsfb->fbdev = drm_fbdev_cma_init(drm, 32, > drm->mode_config.num_connector); > if (IS_ERR(mxsfb->fbdev)) { > + ret = PTR_ERR(mxsfb->fbdev); > mxsfb->fbdev = NULL; > dev_err(drm->dev, "Failed to init FB CMA area\n"); > goto err_cma; Reviewed-by: Gustavo Padovan Gustavo