From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920AbdBFMDT (ORCPT ); Mon, 6 Feb 2017 07:03:19 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:34031 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdBFMDS (ORCPT ); Mon, 6 Feb 2017 07:03:18 -0500 Date: Mon, 6 Feb 2017 13:03:14 +0100 From: Thierry Reding To: Douglas Anderson Cc: seanpaul@chromium.org, marcheu@chromium.org, briannorris@chromium.org, hoegsberg@google.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: simple: ensure Sharp lq123p1jx31 isn't turned off too soon Message-ID: <20170206120314.GK27607@ulmo.ba.sec> References: <20170202233853.13818-1-dianders@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FCF9ydJxlAJsfRTu" Content-Disposition: inline In-Reply-To: <20170202233853.13818-1-dianders@chromium.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FCF9ydJxlAJsfRTu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 02, 2017 at 03:38:53PM -0800, Douglas Anderson wrote: > The Sharp lq123p1jx31 has a requirement that the VDD is on for at > least 300 ms before being turned off. At the moment nothing anywhere > in the kernel is ensuring this. Looks to me like .delay.prepare would be a better fit. That enables the regulator and setting it to 300 ms would make sure that the regulator will always get enabled for at least 300 ms. Anyway, your commit message says nothing about why this is important. What are the side-effects if the above isn't true? Does the display hang in some way? Thierry --FCF9ydJxlAJsfRTu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliYZgEACgkQ3SOs138+ s6EgMA//d1JmGyc3BoCE7bui+2XFPJbCROdPgHl1OfOwKA7FCEflbFIv7vW75N8R DYWTINEyYZpcsihXvVbqQiErNeB7uRisC4exi7iWvNHUSMp8V3ThnOee7CVtsi1k 3wv0nAwDyI5s5xXGuX7Z7fp4M12GqLJA9mIU7HTpCo+iPPg8uUuBPmGqub6rNwMb eaVp8P2WjO7kAjLuBRhXRBRfom631TpjuCzEW5mvUfteI+uE01ZI8gUDrlHvmWm6 MUjalmbsELZjQ8mggtCA02zkIHp7DlyhNuevpyR6hPiBhr3/AmYDz6WZxMxRE+7s /XV0K3nDUtfSWO8y8s1BP8xTwyTMkssvMghYBeG8GNLO9MatCwqUXgWjc3J+MLAP JFh/y4InQRC5LJA8W1DPCLk1focJiKM9YqPe3tQfKHk+n7cRo92lw+xFGEu2ncPY nLfpJVtHX3OmaRqbbj0rEal4L38q1kH4+tbMpwtqpXW7FKa04JKkIPUyCB3aHVMC nVQGjBjrDAy6C7JEsDji/NEZQyLd+ICfWFga708UN1th9nF1j7EurENWA2385KKK wXI+yCjSzMHmdO4O8aKkaiDbSGM+apOa73eYjzocXfrvCdTE+q54/qdSFvQrpNJD hO7sNap7Jmy5M93m0vp+GEAQII7TqSwYVeNlNwGAY1CPEmhzbYU= =JFxU -----END PGP SIGNATURE----- --FCF9ydJxlAJsfRTu--