From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbdBFOwm (ORCPT ); Mon, 6 Feb 2017 09:52:42 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:56062 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432AbdBFOwk (ORCPT ); Mon, 6 Feb 2017 09:52:40 -0500 Date: Mon, 6 Feb 2017 06:52:38 -0800 From: Matthew Wilcox To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter Subject: Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc- Message-ID: <20170206145238.GI2267@bombadil.infradead.org> References: <20170203181008.24898-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203181008.24898-1-vbabka@suse.cz> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2017 at 07:10:08PM +0100, Vlastimil Babka wrote: > diff --git a/mm/slab.c b/mm/slab.c > index a95fd4fed0a8..ede31b59bb9f 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1293,7 +1293,8 @@ void __init kmem_cache_init(void) > * Initialize the caches that provide memory for the kmem_cache_node > * structures first. Without this, further allocations will bug. > */ > - kmalloc_caches[INDEX_NODE] = create_kmalloc_cache("kmalloc-node", > + kmalloc_caches[INDEX_NODE] = create_kmalloc_cache( > + get_kmalloc_cache_name(INDEX_NODE), Could we lose the 'get_' from the front? I think 'kmalloc_cache_name()' is just as informative. Reviewed-by: Matthew Wilcox