From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbdBFPFq (ORCPT ); Mon, 6 Feb 2017 10:05:46 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:35275 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbdBFPFp (ORCPT ); Mon, 6 Feb 2017 10:05:45 -0500 Date: Mon, 6 Feb 2017 16:05:42 +0100 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS Message-ID: <20170206150542.GP6515@twins.programming.kicks-ass.net> References: <1484275324-28192-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484275324-28192-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 11:42:04AM +0900, Byungchul Park wrote: > Bug messages and stack dump for MAX_LOCKDEP_CHAIN_HLOCKS should be > printed only at the first time. > > Signed-off-by: Byungchul Park Indeed, thanks! > --- > kernel/locking/lockdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index f37156f..a143eb4 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -2166,7 +2166,7 @@ static inline int add_chain_cache(struct task_struct *curr, > * Important for check_no_collision(). > */ > if (unlikely(nr_chain_hlocks > MAX_LOCKDEP_CHAIN_HLOCKS)) { > - if (debug_locks_off_graph_unlock()) > + if (!debug_locks_off_graph_unlock()) > return 0; > > print_lockdep_off("BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low!"); > -- > 1.9.1 >