From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbdBFXkw (ORCPT ); Mon, 6 Feb 2017 18:40:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35246 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbdBFXkv (ORCPT ); Mon, 6 Feb 2017 18:40:51 -0500 Date: Mon, 6 Feb 2017 15:40:50 -0800 From: Andrew Morton To: Michal Hocko Cc: Johannes Weiner , Mel Gorman , Minchan Kim , Hillf Danton , linux-mm@kvack.org, LKML , Trevor Cordes Subject: Re: [PATCH 2/3] mm, vmscan: consider eligible zones in get_scan_count Message-Id: <20170206154050.ebfaae2883597176606882b7@linux-foundation.org> In-Reply-To: <20170206081006.GA3085@dhcp22.suse.cz> References: <20170117103702.28542-1-mhocko@kernel.org> <20170117103702.28542-3-mhocko@kernel.org> <20170206081006.GA3085@dhcp22.suse.cz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Feb 2017 09:10:07 +0100 Michal Hocko wrote: > Hi Andrew, > it turned out that this is not a theoretical issue after all. Trevor > (added to the CC) was seeing pre-mature OOM killer triggering [1] > bisected to b2e18757f2c9 ("mm, vmscan: begin reclaiming pages on a > per-node basis"). > After some going back and forth it turned out that b4536f0c829c ("mm, > memcg: fix the active list aging for lowmem requests when memcg is > enabled") helped a lot but it wasn't sufficient on its own. We also > need this patch to make the oom behavior stable again. So I suggest > backporting this to stable as well. Could you update the changelog as > follows? > > The patch would need to be tweaked a bit to apply to 4.10 and older > but I will do that as soon as it hits the Linus tree in the next merge > window. > > ... > > Fixes: b2e18757f2c9 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Cc: stable # 4.8+ > Tested-by: Trevor Cordes No probs.