From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbdBFX4S (ORCPT ); Mon, 6 Feb 2017 18:56:18 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34857 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbdBFX4Q (ORCPT ); Mon, 6 Feb 2017 18:56:16 -0500 From: Florian Fainelli To: netdev@vger.kernel.org Cc: zefir.kurtisi@neratec.com, Florian Fainelli , Sebastian Hesselbarth , Wingman Kwok , Murali Karicheri , Andrew Lunn , Vivien Didelot , "David S. Miller" , Philippe Reynes , Sergei Shtylyov , Jisheng Zhang , Jarod Wilson , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 3/4] net: netcp: Do not clobber PHY link outside of state machine Date: Mon, 6 Feb 2017 15:55:22 -0800 Message-Id: <20170206235523.23216-4-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170206235523.23216-1-f.fainelli@gmail.com> References: <20170206235523.23216-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Calling phy_read_status() means that we may call into genphy_read_status() which in turn will use genphy_update_link() which can make changes to phydev->link outside of the state machine's state transitions. This is an invalid behavior that is now caught as off 811a919135b9 ("phy state machine: failsafe leave invalid RUNNING state") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/ti/netcp_ethss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c index f7bb241b17ab..eece3e2eec14 100644 --- a/drivers/net/ethernet/ti/netcp_ethss.c +++ b/drivers/net/ethernet/ti/netcp_ethss.c @@ -2313,7 +2313,6 @@ static int gbe_slave_open(struct gbe_intf *gbe_intf) dev_dbg(priv->dev, "phy found: id is: 0x%s\n", phydev_name(slave->phy)); phy_start(slave->phy); - phy_read_status(slave->phy); } return 0; } @@ -3119,7 +3118,6 @@ static void init_secondary_ports(struct gbe_priv *gbe_dev, dev_dbg(dev, "phy found: id is: 0x%s\n", phydev_name(slave->phy)); phy_start(slave->phy); - phy_read_status(slave->phy); } } } -- 2.9.3