From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755512AbdBGQoj (ORCPT ); Tue, 7 Feb 2017 11:44:39 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51390 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755491AbdBGQog (ORCPT ); Tue, 7 Feb 2017 11:44:36 -0500 Date: Tue, 07 Feb 2017 11:44:25 -0500 (EST) Message-Id: <20170207.114425.341399611687898005.davem@davemloft.net> To: arnd@arndb.de Cc: jiri@mellanox.com, idosch@mellanox.com, vadimp@mellanox.com, eladr@mellanox.com, cera@cera.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum From: David Miller In-Reply-To: <20170206162642.693506-1-arnd@arndb.de> References: <20170206162642.693506-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Feb 2017 07:45:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 6 Feb 2017 17:26:30 +0100 > When PSAMPLE is a loadable module, spectrum must not be built-in: > > drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func': > spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet' > > This adds a Kconfig dependency to enforce usable configurations. > > Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support") > Signed-off-by: Arnd Bergmann Applied.