From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbdBGS20 (ORCPT ); Tue, 7 Feb 2017 13:28:26 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:53612 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbdBGS2Y (ORCPT ); Tue, 7 Feb 2017 13:28:24 -0500 Date: Tue, 07 Feb 2017 13:28:22 -0500 (EST) Message-Id: <20170207.132822.668043461053676694.davem@davemloft.net> To: sainath.grandhi@intel.com Cc: netdev@vger.kernel.org, mahesh@bandewar.net, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces From: David Miller In-Reply-To: <1486416975-14133-1-git-send-email-sainath.grandhi@intel.com> References: <1486416975-14133-1-git-send-email-sainath.grandhi@intel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Feb 2017 09:29:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sainath Grandhi Date: Mon, 6 Feb 2017 13:36:08 -0800 > Tap character devices can be implemented on other virtual interfaces like > ipvlan, similar to macvtap. Source code for tap functionality in macvtap > can be re-used for this purpose. > > This patch series splits macvtap source into two modules, macvtap and tap. > This patch series also includes a patch for implementing tap character > device driver based on the IP-VLAN network interface, called ipvtap. > > These patches are tested on x86 platform. You're going to have to rework the module and Kconfig parts of this set of changes. The user should not have to modify any existing Kconfig setting to get the same set of modules which already exist today. Yet when I run "make oldconfig" after applying these changes it prompts me for: TAP module support for virtual interfaces (TAP) [N/m/y/?] (NEW) And that's not really acceptable. I had MACVTAP set, I should still get the infrastructure necessary to get that module built. If you want to do patch #6 you have to do it in a way that is transparent to existing kernel configs. Thanks.