From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755125AbdBGS4p (ORCPT ); Tue, 7 Feb 2017 13:56:45 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54582 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754141AbdBGS4m (ORCPT ); Tue, 7 Feb 2017 13:56:42 -0500 Date: Tue, 07 Feb 2017 13:55:48 -0500 (EST) Message-Id: <20170207.135548.37750516957060303.davem@davemloft.net> To: stefan.bruens@rwth-aachen.de Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications From: David Miller In-Reply-To: <20170207.135312.2024064918721070962.davem@davemloft.net> References: <20170207023317.29192-1-stefan.bruens@rwth-aachen.de> <94f1dec53f614c76802adf350f495922@rwthex-w2-b.rwth-ad.de> <20170207.135312.2024064918721070962.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Feb 2017 09:56:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v17Iuono028713 From: David Miller Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST) > From: Stefan Brüns > Date: Tue, 7 Feb 2017 03:33:16 +0100 > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly different indication message. >> The dual-stack indication omits the link_type (IPv4/v6) and adds >> additional address fields. >> IPv6 LSIs are identical to IPv4 LSIs, but have a different link type. >> >> Signed-off-by: Stefan Brüns > > Applied. > > Ignore my earlier comments about the UMTS comment, it is still > accurate of course. :-) Acutally, this still need work. I had to revert. You removed the code using the 'eth' variable from sierra_net_bind() but left the unused variable declared. Please respin this series with it removed so we don't get the warning: drivers/net/usb/sierra_net.c: In function ‘sierra_net_bind’: drivers/net/usb/sierra_net.c:687:17: warning: unused variable ‘eth’ [-Wunused-variable] struct ethhdr *eth;