From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406AbdBGTP6 (ORCPT ); Tue, 7 Feb 2017 14:15:58 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754498AbdBGTP4 (ORCPT ); Tue, 7 Feb 2017 14:15:56 -0500 Date: Tue, 07 Feb 2017 14:05:01 -0500 (EST) Message-Id: <20170207.140501.318284472850132434.davem@davemloft.net> To: colin.king@canonical.com Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set From: David Miller In-Reply-To: <20170207105638.17918-1-colin.king@canonical.com> References: <20170207105638.17918-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Feb 2017 10:06:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 7 Feb 2017 10:56:38 +0000 > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with CoverityScan, CID#140030("Logically dead code") > > Signed-off-by: Colin Ian King Applied.