From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbdBGD6V (ORCPT ); Mon, 6 Feb 2017 22:58:21 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:34675 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdBGD6T (ORCPT ); Mon, 6 Feb 2017 22:58:19 -0500 Date: Tue, 7 Feb 2017 09:28:15 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Amit Daniel Kachhap , Javi Merino , Zhang Rui , Eduardo Valentin , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Dan Carpenter Subject: Re: [PATCH 2/3] thermal: cpu_cooling: Check OPP for errors Message-ID: <20170207035815.GK3131@vireshk-i7> References: <232171cd9d89c2179e10e1f2aed71ad7fc1f7872.1486376756.git.viresh.kumar@linaro.org> <2237771.GAr8QlFsVi@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2237771.GAr8QlFsVi@aspire.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-02-17, 13:02, Rafael J. Wysocki wrote: > On Monday, February 06, 2017 03:56:28 PM Viresh Kumar wrote: > > It is possible for dev_pm_opp_find_freq_exact() to return errors. It was > > all fine earlier as dev_pm_opp_get_voltage() had a check within it to > > check for invalid OPPs, but dev_pm_opp_put() doesn't have any similar > > checks and the callers need to make sure OPP is valid before calling > > them. > > > > Also update the later dev_warn_ratelimited() to not print the error > > message as the OPP is guaranteed to be valid now. > > > > Reported-by: Dan Carpenter > > Signed-off-by: Viresh Kumar > > --- > > drivers/thermal/cpu_cooling.c | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > > index 85fdbf762fa0..9534540434e2 100644 > > --- a/drivers/thermal/cpu_cooling.c > > +++ b/drivers/thermal/cpu_cooling.c > > @@ -431,13 +431,20 @@ static int get_static_power(struct cpufreq_cooling_device *cpufreq_device, > > > > opp = dev_pm_opp_find_freq_exact(cpufreq_device->cpu_dev, freq_hz, > > true); > > + if (IS_ERR(opp)) { > > + dev_warn_ratelimited(cpufreq_device->cpu_dev, > > + "Failed to find OPP for frequency %lu: %ld\n", > > + freq_hz, PTR_ERR(opp)); > > I'm quite unconvinced about the WARN level of these messages. > > They seem to be mostly useful for the people who provide device trees for > platforms (ie. system integrators). If users see them, there is not much > they can do to fix the problem by themselves and the hardware is OK, > actually. Sure. I just wanted to keep it consistent within the function. -- viresh