From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392AbdBGILC (ORCPT ); Tue, 7 Feb 2017 03:11:02 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:48690 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbdBGILA (ORCPT ); Tue, 7 Feb 2017 03:11:00 -0500 X-AuditID: b6c32a59-f79be6d0000012bb-1d-589980f81370 From: Andi Shyti To: Krzysztof Kozlowski , Mark Brown Cc: Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH 2/2] spi: s3c64xx: fix potential division by zero Date: Tue, 07 Feb 2017 17:10:25 +0900 Message-id: <20170207081025.9671-2-andi.shyti@samsung.com> X-Mailer: git-send-email 2.11.0 In-reply-to: <20170207081025.9671-1-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGKsWRmVeSWpSXmKPExsWy7bCmhu6PhpkRBs+3WVlsP/KM1WLxj+dM FlMfPmGzePN2DZPF+fMb2C0u75rDZjHj/D4mi8aPN9kdODyuL/nE7LFpVSebx5b+u+wefVtW MXp83iQXwBqVapORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6Dr lpkDdIuSQlliTilQKCCxuFhJ386mKL+0JFUhI7+4xFYp2tDQSM/QwFzPyMhIz8Q41srIFKgk ITVj/o0FzAXz2CvWbHzD1sD4lrWLkZNDQsBE4u7qWSwQtpjEhXvr2UBsIYGljBLr5+Z3MXIB 2e1MEqf372SBadjybjkLRGIOo8SM2XPYIJyPjBLbJj9gBqliE9CUaLr9A2yUiICXxIQZ98CK mAVuM0rM3bSAESQhLOAosXHbG7AiFgFViSvrG8GaeQWsJD7dWs8MsU5eYlfbRbBbOQWsJXau 38kEMkhC4DubxLQ194EGcQA5shKbDkDVu0hsPLsT6jdhiVfHt7BD2NISf5feYoSwyyXWHtwO NaeFUeL3y6tsEAljifsP7oENYhbgk+j9/YQJYj6vREebEESJh8TJP6eh5jtKfP41kxni+z5G ibMb3zBNYJRZwMiwilEstaA4Nz212LTAVK84Mbe4NC9dLzk/dxMjOA1pRe5gvDIz6BCjAAej Eg+vwdsZEUKsiWXFlbmHGCU4mJVEeI/VzowQ4k1JrKxKLcqPLyrNSS0+xGgKDKeJzFKiyfnA FJlXEm9oYmZoYmQJhOaG5krivFEGEyOEBNITS1KzU1MLUotg+pg4OKUaGHMVtzwIkjTKKztl v2R/8Zq3kU8vL3sv/5VP7ve2ReWP5KdE/vol67JNa866DSu/Vhy7tdPysXuImPWqh//aY9rC gj7HTdR31z906t7qmHk/da7Wn7lYMOf5Hub/RkcWfi38d2JjxfGJrvcya/r++7bZ75qbZGIf ahpYFrJ2stm9g3bVs6ws1cWUWIozEg21mIuKEwFy3d2pWQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t9jQd0fDTMjDOb2aVlsP/KM1WLxj+dM FlMfPmGzePN2DZPF+fMb2C0u75rDZjHj/D4mi8aPN9kdODyuL/nE7LFpVSebx5b+u+wefVtW MXp83iQXwBrlZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4z5NxYwF8xjr1iz8Q1bA+Nb1i5GTg4JAROJLe+Ws0DYYhIX7q1nA7GF BGYxSjw7ptfFyAVkf2SUOL/1GztIgk1AU6Lp9g+wIhEBL4kJM+6xgRQxC9xmlPi0aw8zSEJY wFFi47Y3YEUsAqoSV9Y3gsV5BawkPt1azwyxTV5iV9tFsCs4Bawldq7fyQSx2UrixIsXLBMY eRcwMqxilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93ECA7vZ9I7GA/vcj/EKMDBqMTDG8A5 M0KINbGsuDL3EKMEB7OSCO+xWqAQb0piZVVqUX58UWlOavEhRlOgwyYyS4km5wNjL68k3tDE 3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6pBkbrk7wcc21ClxZ4Kzm/rjZe VhI6bb8OM0dxTrWqZYmq2AGmPG2NZ5+bIsoX3TqrujPsJeuaDXt7NUL9gg6t43qpUle9VFSl zpVPc37RB9Ocp9Vyz9b0MQsnrtYyLt6Qa3TfK+796i1/Xl377XvfW/UD76a/5Rd0KlKv10lF tx2wOxO0RoG/X4mlOCPRUIu5qDgRAHeKHn6FAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170207081032epcas5p3af837bbe00278da4029fc7bb9eba6961 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?= =?UTF-8?B?G+yCvOyEseyghOyekBvssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?= =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170207081032epcas5p3af837bbe00278da4029fc7bb9eba6961 X-RootMTR: 20170207081032epcas5p3af837bbe00278da4029fc7bb9eba6961 References: <20170207081025.9671-1-andi.shyti@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even though it's quite unlikely to happen in this particular case, clk_get_rate can return '0' if sdd->src_clk is not set properly. In that case we would have a clear division by '0'. Check the return value of clk_get_rate and fail in case it returns '0'. This patch fixes '1397922 Division or modulo by zero' from scan.coverity.com Signed-off-by: Andi Shyti --- drivers/spi/spi-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index f6ea9ae047ec..a2ec07f44e33 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -811,6 +811,8 @@ static int s3c64xx_spi_setup(struct spi_device *spi) /* Max possible */ speed = clk_get_rate(sdd->src_clk) / 2 / (0 + 1); + if (!speed) + goto setup_exit; if (spi->max_speed_hz > speed) spi->max_speed_hz = speed; -- 2.11.0