From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbdBGKaK (ORCPT ); Tue, 7 Feb 2017 05:30:10 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57157 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbdBGKaI (ORCPT ); Tue, 7 Feb 2017 05:30:08 -0500 Date: Tue, 7 Feb 2017 11:30:01 +0100 From: Borislav Petkov To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Robert Richter , Vince Weaver , lkml Subject: Re: [PATCH 1/2] tools/lib/api/fs: Add procfs int read/write helpers Message-ID: <20170207103001.kmnnpywb4fdcinrq@pd.tnic> References: <20170206121506.mtknwusus4djp2sx@pd.tnic> <20170206122231.GA9404@gmail.com> <20170206124116.7jmrmufthqtnd3dc@pd.tnic> <20170206124447.GA12772@gmail.com> <20170206124937.zlowglr5gpq35piy@pd.tnic> <20170207010813.buovxbku5rqhnhzg@pd.tnic> <20170207010917.36ysrh6p7yktxwhc@pd.tnic> <20170207014356.GE24988@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170207014356.GE24988@kernel.org> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2017 at 10:43:56PM -0300, Arnaldo Carvalho de Melo wrote: > > int sysctl__read_int(const char *sysctl, int *value); > > Isn't sysctl__read_int() what you want? Right, so looking at this: don't you think that having both sysctl__* and procfs__* is a little redundant? The sysctl* things are doing the accesses over proc so shouldn't it all be procfs__* interfaces and no sysctl__* ones at all or at least the sysctl__* ones should call the procfs__* ones? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.