From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbdBGL3Q (ORCPT ); Tue, 7 Feb 2017 06:29:16 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:46228 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdBGL3O (ORCPT ); Tue, 7 Feb 2017 06:29:14 -0500 From: Colin King To: Adaptec OEM Raid Solutions , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero Date: Tue, 7 Feb 2017 11:27:38 +0000 Message-Id: <20170207112738.18486-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The check on rcode >= 0 is always true because rcode is unsigned and can never be less than zero. Remove the redundant check. Signed-off-by: Colin Ian King --- drivers/scsi/aacraid/aachba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 3b5ddf4..ddfd726 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan) FsaNormal, 1, 1, NULL, NULL); /* analyse data */ - if (rcode >= 0 && phys_luns->resp_flag == 2) { + if (phys_luns->resp_flag == 2) { /* ok and extended reporting */ aac_update_hba_map(dev, phys_luns, rescan); } -- 2.10.2