From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbdBGVo5 (ORCPT ); Tue, 7 Feb 2017 16:44:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57144 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbdBGVoz (ORCPT ); Tue, 7 Feb 2017 16:44:55 -0500 Date: Tue, 7 Feb 2017 13:44:54 -0800 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mprotect: drop overprotective lock_pte_protection() Message-Id: <20170207134454.7af755ae379ca9d016b5c15a@linux-foundation.org> In-Reply-To: <20170207143347.123871-1-kirill.shutemov@linux.intel.com> References: <20170207143347.123871-1-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Feb 2017 17:33:47 +0300 "Kirill A. Shutemov" wrote: > lock_pte_protection() uses pmd_lock() to make sure that we have stable > PTE page table before walking pte range. > > That's not necessary. We only need to make sure that PTE page table is > established. It cannot vanish under us as long as we hold mmap_sem at > least for read. > > And we already have helper for that -- pmd_trans_unstable(). http://ozlabs.org/~akpm/mmots/broken-out/mm-mprotect-use-pmd_trans_unstable-instead-of-taking-the-pmd_lock.patch already did this?