From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932721AbdBGVtv (ORCPT ); Tue, 7 Feb 2017 16:49:51 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57450 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932493AbdBGVts (ORCPT ); Tue, 7 Feb 2017 16:49:48 -0500 Date: Tue, 7 Feb 2017 13:49:36 -0800 From: Andrew Morton To: Thomas Garnier Cc: Sean Rees , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML Subject: Re: [PATCH] mm/slub: Fix random_seq offset destruction Message-Id: <20170207134936.2cd986e5b673352d30cfad45@linux-foundation.org> In-Reply-To: References: <20170207140707.20824-1-sean@erifax.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Feb 2017 07:41:13 -0800 Thomas Garnier wrote: > On Tue, Feb 7, 2017 at 6:07 AM, Sean Rees wrote: > > Bailout early from init_cache_random_seq if s->random_seq is already > > initialised. This prevents destroying the previously computed random_seq > > offsets later in the function. > > > > If the offsets are destroyed, then shuffle_freelist will truncate > > page->freelist to just the first object (orphaning the rest). > > > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=177551. > > > > Signed-off-by: Sean Rees > > Please add: > > Fixes: 210e7a43fa90 ("mm: SLUB freelist randomization") I also added Reported-by: Cc: