From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/panel: Add driver for sitronix ST7789V panel
Date: Tue, 7 Feb 2017 16:53:34 +0100 [thread overview]
Message-ID: <20170207155334.fq4emlhpj4hkhets@lukather> (raw)
In-Reply-To: <20170206132620.GB28955@ulmo.ba.sec>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Mon, Feb 06, 2017 at 02:26:20PM +0100, Thierry Reding wrote:
> > +#define NUMARGS(...) (sizeof((int[]){__VA_ARGS__}) / sizeof(int))
> > +#define st7789v_send(ctx, cmd, ...) \
> > + st7789v_write_command_data(ctx, cmd, NUMARGS(__VA_ARGS__), \
> > + ##__VA_ARGS__)
>
> How is this going to work if any of the arguments happens to not be an
> int? What if you have something like this:
>
> u8 value = 0x2;
>
> st7789v_write_command_data(ctx, cmd, 0x1, value, 0x3);
>
> ? Wouldn't that invalidly read "value" as int and wrongly increment the
> ap by three bytes too many?
Hmmm, it might be. I'll remove it, and take all your other changes
into account.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-07 15:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:59 [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V Maxime Ripard
2017-02-03 9:59 ` [PATCH 1/2] dt-bindings: display: panel: Add bindings for the Sitronix ST7789V panel Maxime Ripard
2017-02-06 13:05 ` Thierry Reding
2017-02-07 15:44 ` Maxime Ripard
2017-02-07 16:42 ` Thierry Reding
2017-02-03 9:59 ` [PATCH 2/2] drm/panel: Add driver for sitronix " Maxime Ripard
2017-02-03 18:53 ` Noralf Trønnes
2017-02-06 10:50 ` Maxime Ripard
2017-02-06 12:13 ` Noralf Trønnes
2017-02-06 12:25 ` Thierry Reding
2017-02-06 13:26 ` Thierry Reding
2017-02-07 15:53 ` Maxime Ripard [this message]
2017-02-03 9:59 ` [PATCH v3 1/2] dt-bindings: gpu: Add Mali Utgard bindings Maxime Ripard
2017-02-03 9:59 ` [PATCH v3 2/2] ARM: sun8i: dt: Add mali node Maxime Ripard
2017-02-03 18:48 ` [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V Noralf Trønnes
2017-02-06 10:39 ` Maxime Ripard
2017-02-06 11:29 ` Noralf Trønnes
2017-02-07 15:34 ` Maxime Ripard
2017-02-07 16:46 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207155334.fq4emlhpj4hkhets@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®