From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753775AbdBGLCw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Feb 2017 06:02:52 -0500
Received: from mail.kernel.org ([198.145.29.136]:40668 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752149AbdBGLCv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Feb 2017 06:02:51 -0500
Date: Tue, 7 Feb 2017 20:02:40 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH tip/master] tracing/probes: Fix a warning message to
 show correct maximum length
Message-Id: <20170207200240.6197452afe8850cfe36206ed@kernel.org>
In-Reply-To: <20170207074148.GA24528@gmail.com>
References: <148643715974.9770.191313097974521280.stgit@devbox>
        <20170207074148.GA24528@gmail.com>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 7 Feb 2017 08:41:48 +0100
Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > Since tracing/*probe_events will accept a probe definition
> > up to 4096 - 2 ('\n' and '\0') bytes, it must show 4094 instead
> > of 4096 in warning message.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> >  kernel/trace/trace_probe.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> > index 8c0553d..7138fea 100644
> > --- a/kernel/trace/trace_probe.c
> > +++ b/kernel/trace/trace_probe.c
> > @@ -673,8 +673,9 @@ ssize_t traceprobe_probes_write(struct file *file, const char __user *buffer,
> >  			*tmp = '\0';
> >  			size = tmp - kbuf + 1;
> >  		} else if (done + size < count) {
> > +			/* This can accept WRITE_BUFSIZE - 2 ('\n' + '\0') */
> >  			pr_warn("Line length is too long: Should be less than %d\n",
> > -				WRITE_BUFSIZE);
> > +				WRITE_BUFSIZE - 2);
> 
> The message should also indicate which kernel subsystem generated it - which is 
> useful if the message is not immediately noticed in the kernel log.
> 
> You can do this by having something like this at the top of the trace_probe file:
> 
>   #define pr_fmt(fmt) "trace_probe: " fmt

Ah, I got it. I'll make a separate patch for that.

Thank you!

-- 
Masami Hiramatsu <mhiramat@kernel.org>