From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbdBGUet (ORCPT ); Tue, 7 Feb 2017 15:34:49 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33130 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbdBGUed (ORCPT ); Tue, 7 Feb 2017 15:34:33 -0500 Date: Tue, 7 Feb 2017 22:33:36 +0200 From: Krzysztof Kozlowski To: Andi Shyti Cc: Mark Brown , Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] spi: s3c64xx: fix inconsistency between binding and driver Message-ID: <20170207203336.3oetygxh4eofqlml@kozik-lap> References: <20170207080748.9524-1-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170207080748.9524-1-andi.shyti@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2017 at 05:07:48PM +0900, Andi Shyti wrote: > Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS > line is not connected") introduced an inconsistency between the > binding where the disconnected CS line was marked as > 'no-cs-readback' while the driver was erroneously checking for > 'broken-cs'. Please describe in one sentence the visible output of this error to justify backporting and then: Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") Cc: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof