From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572AbdBGVMl (ORCPT ); Tue, 7 Feb 2017 16:12:41 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35996 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbdBGVMj (ORCPT ); Tue, 7 Feb 2017 16:12:39 -0500 Date: Tue, 7 Feb 2017 23:12:33 +0200 From: Krzysztof Kozlowski To: Andi Shyti Cc: Rob Herring , Javier Martinez Canillas , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Message-ID: <20170207211233.ge3fzw5x2fvebpjq@kozik-lap> References: <20170207081325.9769-1-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170207081325.9769-1-andi.shyti@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2017 at 05:13:25PM +0900, Andi Shyti wrote: > Add the device tree node for the ir-spi driver which enable the > ir led for remote controlling. > > This patch sets first the GPR3[3] gpio line as a regulator-fixed > for enabling an external regulator which powers the IR LED. > > Removes also the default assignment of the GPG3[5] and GPG3[7] > related to the SPI3 line. > > Signed-off-by: Andi Shyti > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 27 ++++++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 098ad557fee3..c61df2318d8b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -106,6 +106,13 @@ > }; > }; > > + irda_regulator: irda-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpr3 3 0>; GPIO_ACTIVE_HIGH > + regulator-name = "irda_regulator"; > + }; > + > sound { > compatible = "samsung,tm2-audio"; > audio-codec = <&wm5110>; > @@ -1073,8 +1080,6 @@ > > PIN(INPUT, gpg3-0, DOWN, FAST_SR1); > PIN(INPUT, gpg3-1, DOWN, FAST_SR1); > - PIN(INPUT, gpg3-5, DOWN, FAST_SR1); > - PIN(INPUT, gpg3-7, DOWN, FAST_SR1); I think gpg3-5 would be missing its configuration. It is not present in spi3 bus pins. Is it a chip select pin? If you remove the default configuration, it will still work as input-pull down because no one is setting different config. Why you need to touch gpg3-5? Best regards, Krzysztof