From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755687AbdBHB13 (ORCPT ); Tue, 7 Feb 2017 20:27:29 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57191 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbdBHB12 (ORCPT ); Tue, 7 Feb 2017 20:27:28 -0500 X-ME-Sender: X-Sasl-enc: Lu/uaZl1AxHZSQdoVIY4KulnvSGA9XjuKYobdUpEz+/i 1486515695 Date: Tue, 7 Feb 2017 23:01:32 -0200 From: Henrique de Moraes Holschuh To: Adam Goode Cc: Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [ibm-acpi-devel] [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Message-ID: <20170208010132.GB7028@khazad-dum.debian.net> References: <20170119172132.36029-1-agoode@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Adam, I apologise for the delay on answering you. On Tue, 31 Jan 2017, Adam Goode wrote: > On Thu, Jan 19, 2017 at 12:21 PM, Adam Goode wrote: > > This allows the control of the red status LED, which is the dot of the "i" > > in the word "ThinkPad" on the outside cover of newer models. > > > > In the manual, both this LED and the power LED are referred to as > > the "system-status indicators" without distinction between the two, so > > I chose "status" as the LED name. I seem to recall this LED had an ACPI interface that was specific for it, and allowed it to on/off/sine-wave? > > Signed-off-by: Adam Goode > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/ > > thinkpad_acpi.c > > index cacb43fb1df7..6577bf8e5635 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -5611,11 +5611,11 @@ static const char * const > > tpacpi_led_names[TPACPI_LED_NUMLEDS] = { > > "tpacpi::standby", > > "tpacpi::dock_status1", > > "tpacpi::dock_status2", > > - "tpacpi::unknown_led2", > > + "tpacpi::status", > > "tpacpi::unknown_led3", > > "tpacpi::thinkvantage", > > }; > > -#define TPACPI_SAFE_LEDS 0x1081U > > +#define TPACPI_SAFE_LEDS 0x1481U What happens on older Lenovo models (x00, x10, x20 series?)? I think the T410 already had it... Also, please add code to not export it to userspace (as a led class) on IBM. -- Henrique Holschuh